Skip to content

chore(deps): update dependency typescript to v6#9162

Merged
eliandoran merged 2 commits intomainfrom
renovate/typescript-6.x
Mar 31, 2026
Merged

chore(deps): update dependency typescript to v6#9162
eliandoran merged 2 commits intomainfrom
renovate/typescript-6.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Mar 24, 2026

  • Fix TS5101: Remove deprecated downlevelIteration from tsconfig.base.json
  • Fix TS5101: Remove deprecated baseUrl from individual tsconfig files
  • Fix TS2882: Add noUncheckedSideEffectImports: false to tsconfig.base.json and ckeditor5 package tsconfigs to allow CSS/plugin side-effect imports
  • Fix TS2503: Replace NodeJS.Timeout with ReturnType<typeof setTimeout> in debounce.ts
  • Validate all fixes with typecheck (exit code 0)

@renovate renovate Bot added dependencies PRs or issues relating to dependencies renovate labels Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2026

📚 Website preview is ready!

🔗 Preview URL: https://pr-9162.trilium-homepage.pages.dev
📖 Production URL: https://triliumnotes.org

✅ All checks passed

This preview will be updated automatically with new commits.

@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 6930f1e to d72d9ce Compare March 24, 2026 11:57
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from d72d9ce to e8ed4bc Compare March 24, 2026 12:02
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from e8ed4bc to 91e0510 Compare March 24, 2026 12:28
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 91e0510 to 16477e9 Compare March 24, 2026 16:00
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 16477e9 to 1c7a7b8 Compare March 24, 2026 21:30
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 1c7a7b8 to 0bfb1d7 Compare March 24, 2026 21:32
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 0bfb1d7 to 52c7e87 Compare March 25, 2026 06:27
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 52c7e87 to 5e16d37 Compare March 25, 2026 07:54
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 5e16d37 to 3e8b1c9 Compare March 25, 2026 15:06
@renovate renovate Bot force-pushed the renovate/typescript-6.x branch from 7af9cb1 to acfc3f6 Compare March 31, 2026 11:14
@eliandoran
Copy link
Copy Markdown
Contributor

@copilot , please fix the typecheck issues caused by the upgrade of the typescript dependency.

- Remove deprecated `downlevelIteration` from tsconfig.base.json (not needed for ES2022+ target)
- Add `noUncheckedSideEffectImports: false` to tsconfig.base.json and ckeditor5 package tsconfigs to allow CSS/plugin side-effect imports
- Remove deprecated `baseUrl: "."` from 6 package tsconfig.lib.json files (unused without `paths`)
- Replace `NodeJS.Timeout` with `ReturnType<typeof setTimeout>` in debounce.ts

Agent-Logs-Url: https://github.com/TriliumNext/Trilium/sessions/8e861e56-2be6-4c61-9558-a666abbe3ff0

Co-authored-by: eliandoran <21236836+eliandoran@users.noreply.github.com>
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

@copilot , please fix the typecheck issues caused by the upgrade of the typescript dependency.

Fixed in commit 819c9a7. The TypeScript 6 typecheck issues were resolved with these changes:

  1. Removed deprecated downlevelIteration from tsconfig.base.json — not needed for ES2022+ targets
  2. Removed deprecated baseUrl: "." from 6 package tsconfig files — unused since no paths mappings depend on it
  3. Added noUncheckedSideEffectImports: false to tsconfig.base.json and the 5 CKEditor plugin tsconfigs — TypeScript 6 enables this check in strict mode, causing failures for CSS and dayjs plugin side-effect imports
  4. Replaced NodeJS.Timeout with ReturnType<typeof setTimeout> in debounce.ts — removes the @types/node namespace dependency, works cross-environment

tsc --build now exits with code 0.

Copilot AI requested a review from eliandoran March 31, 2026 19:25
@renovate
Copy link
Copy Markdown
Contributor Author

renovate Bot commented Mar 31, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions
Copy link
Copy Markdown
Contributor

📚 Documentation preview is ready!

🔗 Preview URL: https://pr-9162.trilium-docs.pages.dev
📖 Production URL: https://docs.triliumnotes.org

✅ All checks passed

This preview will be updated automatically with new commits.

@eliandoran eliandoran modified the milestone: v0.103.0 Mar 31, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 31, 2026
@eliandoran eliandoran merged commit 8b5b32f into main Mar 31, 2026
13 checks passed
@eliandoran eliandoran deleted the renovate/typescript-6.x branch March 31, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs or issues relating to dependencies lgtm This PR has been approved by a maintainer renovate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants