add support for azure access_token#41
Open
saurabh-gupta-pingsafe wants to merge 1 commit into
Open
Conversation
nishant-pingsafe
approved these changes
Oct 22, 2023
Contributor
|
Hi @saurabh-gupta-pingsafe and @nishant-pingsafe, could you provide some context as to why this change is being requested? I'd also like to see a test case showing the current behavior with any error messages produced, along with the new behavior showing success. |
Author
|
Hi @bahamat , When we run docker login V2 on azure container registry, it throws the following error This is because azure container registry returns token in the field called "access_token" but currently we are only checking on "token". I have added support for "access_token" as well. With access token, the login works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.