ADMINUI-2331 Support for viewing and update of service configurations#222
Open
andyYatskov wants to merge 1 commit into
Open
ADMINUI-2331 Support for viewing and update of service configurations#222andyYatskov wants to merge 1 commit into
andyYatskov wants to merge 1 commit into
Conversation
Contributor
|
🆗 |
| auth.requireRole('operators'), | ||
| resume, | ||
| bodyParser, | ||
| services.updateService); |
Contributor
|
🔢 |
andyYatskov
force-pushed
the
dev-2331
branch
4 times, most recently
from
September 5, 2016 10:44
caebda7 to
3474426
Compare
Contributor
|
🔢 |
andyYatskov
force-pushed
the
dev-2331
branch
from
September 12, 2016 12:05
3474426 to
e83bdaf
Compare
dan-luk
suggested changes
Sep 21, 2016
| </h1> | ||
| </div> | ||
| {this.state.error && <ErrorAlert error={this.state.error} />} | ||
| <section className="params"> |
Contributor
There was a problem hiding this comment.
Angela Fong
8:55 AM
This entire section (L75:L114) is actually not required to be displayed for a service: 1) Customer metadata are not applicable to services, 2) Tags are view-only and aren't supposed to be something user has control over.
dan-luk
previously approved these changes
Sep 21, 2016
Contributor
|
🔢 |
andyYatskov
force-pushed
the
dev-2331
branch
from
September 21, 2016 11:14
415fb8b to
f2ab26f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.