Updated warnings and errors for automations email steps

[troyciesco]

closes NY-1301

What changed

• Added a confirmation dialog before deleting send email steps from the Automations canvas.
• Kept the existing immediate deletion behavior for non-email steps.
• allows saving automations with send_email steps that have an empty body/subject, but does not allow publishing the automation until those fields are filled in.
• Added unit coverage for cancelling and confirming email deletion.

This replaces #28309 but has a few extra pieces of cleanup and fixes merge conflicts from other automations changes

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7a4f1f8f-a176-475a-a68d-5394c29178d3

📥 Commits

Reviewing files that changed from the base of the PR and between 1ed775f and fce88d1.

📒 Files selected for processing (1)

• apps/posts/src/views/Automations/editor.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/posts/src/views/Automations/editor.tsx

---

Walkthrough

This PR enforces publish-time validation for send_email steps (non-empty subject and non-empty lexical body) while allowing empty fields in drafts. It changes the default send_email subject to an empty string, adds editor logic to compute per-action errors and block activation, surfaces errors on canvas nodes and sidebar, adds conditional delete confirmation for email steps, refactors email-modal/preview validation, updates backend validation to reject activating automations with empty email subject/body, and adds/updates unit and e2e tests and fixtures.

Possibly related PRs

• TryGhost/Ghost#28035: Modifies automations step-deletion flow, adding special confirmation/behavior for deleting send_email when email body is empty.
• TryGhost/Ghost#27878: Related backend validation/schema work for automations send_email fields and JSON-parsed email_lexical.
• TryGhost/Ghost#28117: Touches the same action-builder and email-content editor/placeholder logic used by this PR.

Suggested labels

ok to merge for me

Suggested reviewers

• EvanHahn

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding warnings and errors for automation email steps, which aligns with the PR's core objective of improving validation and user feedback.
Description check	✅ Passed	The description is well-related to the changeset, detailing specific changes (confirmation dialogs, save-vs-publish validation, deletion behavior) that align with the file modifications and PR objectives.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch NY-1301_automations-errs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.79%. Comparing base (a035cf1) to head (fce88d1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ore/server/services/automations/automations-api.ts	86.04%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #28364      +/-   ##
==========================================
+ Coverage   73.77%   73.79%   +0.02%     
==========================================
  Files        1537     1536       -1     
  Lines      130707   130889     +182     
  Branches    15683    15688       +5     
==========================================
+ Hits        96425    96596     +171     
- Misses      33292    33303      +11     
  Partials      990      990              

Flag	Coverage Δ
admin-tests	54.67% <ø> (ø)
e2e-tests	73.79% <86.04%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

apps/posts/src/views/Automations/components/automation-canvas.tsx (1)

345-362: ⚡ Quick win

Consider extracting isEmptyEmailLexical to a shared utility.

This function is duplicated in editor.tsx (lines 16-33) with identical logic. While not a critical issue, extracting it to a shared location would improve maintainability and reduce the risk of divergence.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/posts/src/views/Automations/components/automation-canvas.tsx` around
lines 345 - 362, Extract the duplicated isEmptyEmailLexical function into a
shared utility module (e.g., export a named function isEmptyEmailLexical from a
new util file) and replace both local implementations in automation-canvas.tsx
(function isEmptyEmailLexical) and editor.tsx with an import from that module;
keep the same function signature and behavior, export it as a named export,
update imports in both components, and remove the duplicate code blocks so both
files reuse the single shared implementation.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/posts/src/views/Automations/editor.tsx`:
- Around line 200-205: The onError handler in the editMutation.mutate call
should accept the mutation error and only show the validation-specific
description when there are actual validation errors; update the onError
signature to receive the error (e.g., onError: (err) => { ... }), call or
re-check validateActionErrors()/actionErrors (or check the existing actionErrors
state) and setEditState(errorState) as before, but only pass description: 'Fix
the highlighted steps and try again.' to toast.error when actionErrors is
non-empty (otherwise show a generic error message or no description), ensuring
this change is applied inside the editMutation.mutate onError handler referenced
in editor.tsx.

---

Nitpick comments:
In `@apps/posts/src/views/Automations/components/automation-canvas.tsx`:
- Around line 345-362: Extract the duplicated isEmptyEmailLexical function into
a shared utility module (e.g., export a named function isEmptyEmailLexical from
a new util file) and replace both local implementations in automation-canvas.tsx
(function isEmptyEmailLexical) and editor.tsx with an import from that module;
keep the same function signature and behavior, export it as a named export,
update imports in both components, and remove the duplicate code blocks so both
files reuse the single shared implementation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d75c8d2-33ea-456f-a0eb-5fce9272b91d

📥 Commits

Reviewing files that changed from the base of the PR and between 24244bb and 864887e.

📒 Files selected for processing (10)

• apps/admin-x-framework/src/api/automations.ts
• apps/admin-x-framework/test/unit/api/automations.test.ts
• apps/posts/src/views/Automations/components/automation-canvas.tsx
• apps/posts/src/views/Automations/components/email-modal/email-content-modal.tsx
• apps/posts/src/views/Automations/components/email-modal/use-email-preview.ts
• apps/posts/src/views/Automations/editor.tsx
• apps/posts/test/unit/views/automations/automation-editor.test.tsx
• ghost/core/core/server/services/automations/automations-api.ts
• ghost/core/test/e2e-api/admin/automations.test.js
• ghost/core/test/unit/server/services/automations/automations-api.test.js