Started waiting for member insertion before triggering automation

[EvanHahn]

towards https://linear.app/ghost/issue/NY-1286
ref #28120

I recommend reviewing this with whitespace changes disabled.

What: We want to trigger automations after members are inserted.

Why: If we don't do this, automations could run before the member exists in the database.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0af9f6ec-a60d-46d0-9d2f-7f2245a242a4

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7e1ee and e04da95.

📒 Files selected for processing (1)

• ghost/core/core/server/services/members/members-api/repositories/member-repository.js

🚧 Files skipped from review as they are similar to previous changes (1)

• ghost/core/core/server/services/members/members-api/repositories/member-repository.js

---

Walkthrough

The PR updates member signup automation triggering to be transaction-aware. The private helper #triggerMemberSignupAutomation now accepts bookshelfOptions; if a Bookshelf transaction is present it defers calling automationsApi.trigger('member_sign_up') until transacting.executionPromise resolves and logs any errors, otherwise it triggers and awaits immediately. The public triggerMemberSignupAutomation now forwards bookshelfOptions into the private helper.

Possibly related PRs

• TryGhost/Ghost#28263: Both PRs modify the member-signup automation triggering flow in member-repository.js—Started inserting automation run when member signs up #28263 introduces triggerMemberSignupAutomation/automation-run insertion, and this PR refines that same helper to accept bookshelfOptions and defer automation triggering until after transaction completion.

Suggested labels

ok to merge for me

Suggested reviewers

• troyciesco

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: deferring automation triggering until after member insertion completes within a transaction context.
Description check	✅ Passed	The description clearly relates to the changeset by explaining the motivation (prevent automations running before member exists) and the solution approach (wait for member insertion).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch trigger-member-signup-in-separate-transaction

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}