Added automations beta feature toggle#28379
Draft
EvanHahn wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EvanHahn
force-pushed
the
add-automations-beta-feature
branch
from
d091006 to
eb009a3
Compare
EvanHahn
added a commit
that referenced
this pull request
Jun 8, 2026
towards https://linear.app/ghost/issue/NY-1321 *This change should have no user impact.* This fixes two things with `<Toggle>`: - Updates the props so the component is either [controlled or uncontrolled][0]. In other words, it should be impossible to pass `checked` without passing `onChange`, and vice-versa. - Uses `checked`, not `defaultChecked`, to properly control the input. This means we can update `<Toggle>`s without having to extra work to make it re-render. I think this is a useful change on its own, but will also make [an upcoming change][1] easier. [0]: https://react.dev/reference/react-dom/components/input#controlling-an-input-with-a-state-variable [1]: #28379
EvanHahn
added a commit
that referenced
this pull request
Jun 8, 2026
towards https://linear.app/ghost/issue/NY-1321 *This change should have no user impact.* This fixes two things with `<Toggle>`: - Updates the props so the component is either [controlled or uncontrolled][0]. In other words, it should be impossible to pass `checked` without passing `onChange`, and vice-versa. - Uses `checked`, not `defaultChecked`, to properly control the input. This means we can update `<Toggle>`s without having to extra work to make it re-render. I think this is a useful change on its own, but will also make [an upcoming change][1] easier. [0]: https://react.dev/reference/react-dom/components/input#controlling-an-input-with-a-state-variable [1]: #28379
EvanHahn
force-pushed
the
add-automations-beta-feature
branch
from
eb009a3 to
edc8a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/ghost/issue/NY-1321
ref #28384
Beta.feature.mp4
Blocked by #28384.