Conversation
closes https://linear.app/ghost/issue/NY-1302 This change should have no user impact. This refactor should (hopefully) make things a bit easier to read.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR refactors the automation editor's edit-state state machine from string-based literals to a discriminated union { phase, action }. Types were updated to constrain actions per phase. The editor's state initializer, failure-detection helper, draft-change recovery, save() request/error mapping, mutation callbacks, alert/activity derivation, nested UI switch logic for buttons/variants, and confirm dialog/open-close handlers were all updated to read and set the new object-shaped states. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
closes https://linear.app/ghost/issue/NY-1302
This change should have no user impact.
This refactor should (hopefully) make things a bit easier to read.