Update AbstractClientPlayerEntityMixin.java#2
Open
StonksMan001 wants to merge 2 commits intoTutorials-By-Kaupenjoe:mainfrom
Open
Update AbstractClientPlayerEntityMixin.java#2StonksMan001 wants to merge 2 commits intoTutorials-By-Kaupenjoe:mainfrom
StonksMan001 wants to merge 2 commits intoTutorials-By-Kaupenjoe:mainfrom
Conversation
It is much better to use @WrapOperation here instead of @Inject. Also it is a bad practice to extend mixin classes so also don't do that.
Update AbstractClientPlayerEntityMixin.java
|
@StonksMan001 I am not a owner of this repo, but did you test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In your bow tutorial video, you used a mixin with an @Inject to add zoom to your custom bow. I think that it is much better to use @WrapOperation from MixinExtras in this case instead of @Inject, and it is also much simpler. Also it is a bad practice to extend mixin classes so also don't do that. If you want to refer to the current instance you should use an ((Object) this) cast and then an instanceof check.