Open
Conversation
Removed ChipTactic and KickTactic messages from tactic.proto. Added reserved fields for identifiers 2 and 7.
Contributor
|
@StarrryNight Closing this PR for now, create an issue to track this if you think it should be picked up later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #3236 . It combines kick fsm and chip fsm into one fsm, kick or chip fsm. Before the refactor, these two fsms shares practically the same structure. Both of them are also only used in scenarios when the ball is static, such as during free kick play or penalty kick play. This refactor uses an enum to pass in chip/kick and its corresponding parameters, streamlining the codebase.
Testing Done
Tests from kick fsm and chip fsm are moved into one single test file for kick and chip fsm. All tests passed.
Resolved Issues
#3236
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue