Remove all c++ simulated tests#3676
Open
nycrat wants to merge 7 commits intoUBC-Thunderbots:masterfrom
Open
Conversation
nycrat
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
nycrat
force-pushed
the
avah/deprecate_cpp_tests
branch
from
0bac289 to
0c55b0d
Compare
Andrewyx
previously approved these changes
Apr 5, 2026
nycrat
force-pushed
the
avah/deprecate_cpp_tests
branch
from
1dcd518 to
b440d66
Compare
Contributor
|
@williamckha Can you verify this is a safe action now? |
Member
Not sure, I haven't been keeping up to date with the status of porting our sim tests. I would assume Eric and team have a better idea of what's left to be ported (which by the look of things, seems like none) |
Member
Author
Changes to port rest of the c++ tests are in #3632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gets rid of all er force simulated tests written in c++, and all the code that relates to it such as validation functions.
Testing Done
Resolved Issues
resolves #2581, resolves #2510
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue