Defer Lane 1 checkpoint deploy until after technical edit#108
Merged
Conversation
The Lane 1 checkpoint deploy now happens after the technical edit completes (when the author checks the PR description checkbox), not after Lead Civil approval. The technical edit reads source MDX directly via /technical-edit and posts inline comments on the PR, so no deploy is required during that stage. The live site only ever sees the post-tech-edit version of the document, and the Director reviews the same version that will eventually be merged. Updates the stage-progression workflow's two relevant comment templates and the corresponding Lane 1 descriptions in both planning documents.
Adds an always-runs ci-build.yml workflow that runs npm run build on every PR, providing a meaningful required status check that catches broken builds before merge. Unlike deploy.yml's build job (which only runs on push to main) and pr-preview.yml (which is path-conditional), this workflow fires on every PR and is therefore safe to mark as a required check. Updates pr-preview.yml to (1) include the head commit SHA in the success comment so reviewers can verify which commit they are seeing, and (2) on build failure, append a 'preview is stale' warning to the sticky comment so reviewers cannot unknowingly click through to outdated content. If no previous successful preview exists, post a fresh 'preview build failed' comment instead. Documents the new workflow in planning/01-repo-implementation.md and adds an architectural note about which checks are appropriate as required status checks on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #107 — this commit was made after #107 merged, so it ships separately rather than as part of the original infrastructure PR.