Skip to content

Fix year caching not updating for new PDFs #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TyHil wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix year caching not updating for new PDFs #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion parser/budgetsParser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"strings"
"sync"
"time"
"unicode"

"github.com/UTDNebula/api-tools/utils"
"github.com/UTDNebula/nebula-api/api/schema"
Expand Down Expand Up @@ -398,12 +399,15 @@ func parseBudgetPdfs(paths []string) (schema.Budget, error) {
year := filepath.Base(filepath.Dir(paths[0]))

// Read PDFs
// WARNING: Changes to nameBuilder will invalidate all cached AI responses, only change if necessary
var nameBuilder strings.Builder
var contentBuilder strings.Builder
for _, path := range paths {
content, err := utils.ReadPdf(path, -1)
if err != nil {
return schema.Budget{}, err
}
nameBuilder.WriteString(strings.ReplaceAll(strings.ToLower(removeAllWhitespace(filepath.Base(path))), ".pdf", ""))
contentBuilder.WriteString("# " + filepath.Base(path) + "\n\n")
contentBuilder.WriteString(content + "\n\n\n")
}
Expand All @@ -413,7 +417,7 @@ func parseBudgetPdfs(paths []string) (schema.Budget, error) {
promptFilled := fmt.Sprintf(budgetPrompt, year, year, content)

// Check cache
cacheName := year + ".json"
cacheName := year + "-" + strings.TrimSpace(nameBuilder.String()) + ".json"
result, err := utils.CheckCache(cacheName, apiBucket)
if err != nil {
return schema.Budget{}, err
Expand Down Expand Up @@ -466,6 +470,18 @@ func parseBudgetPdfs(paths []string) (schema.Budget, error) {
return budget, nil
}

// Remove whitespace including non-ASCII
// Because the 2018, 2018, and 2022 budgets have non-unicode spaces in their file names
func removeAllWhitespace(s string) string {
result := make([]rune, 0, len(s))
for _, r := range s {
if !unicode.IsSpace(r) {
result = append(result, r)
}
}
return string(result)
}

// Get the storage bucket for the budget cache
func getBudgetBucket() (string, error) {
apiBucket, err := utils.GetEnv("NEBULA_API_BUDGET_STORAGE_BUCKET")
Expand Down
Loading