Skip to content

GH#1038: add _reload_done circuit-breaker to thank-you.js stopped branch #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 4 commits into from
Apr 30, 2026
Merged

GH#1038: add _reload_done circuit-breaker to thank-you.js stopped branch #1040

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ce3970
GH#1007: fix: initialize Site_Exporter before the requirements/setup …
superdav42 Apr 30, 2026
2a555e4
GH#1006: fix: register mu-migration WP-CLI commands early in Site_Exp…
superdav42 Apr 30, 2026
bcee8d4
fix: add _reload_done circuit-breaker to thank-you.js stopped branch
superdav42 Apr 30, 2026
436a28d
Merge branch 'main' into bugfix/qd-1038-quality-debt--pr972-feedback
superdav42 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions assets/js/thank-you.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ document.addEventListener("DOMContentLoaded", () => {
// navigation and break the infinite-reload loop that occurred when the
// "stopped" branch fired window.location.reload() on every page load
// after site creation had already finished.
is_post_redirect: new URLSearchParams(window.location.search).has("_t")
is_post_redirect: new URLSearchParams(window.location.search).has("_t"),
// One-time guard for the Case 1 "stopped" reload. Multiple
// check_site_created() callbacks can be queued before the first reload
// fires (async polling overlap), so we set this flag before calling
// window.location.reload() and bail out of subsequent calls.
_reload_done: false
};
},
computed: {
Expand Down Expand Up @@ -205,8 +210,11 @@ document.addEventListener("DOMContentLoaded", () => {
this.creating = false;
this.stopped_count++;
if (this.stopped_count >= 3) {
if (this.running_count > 0) {
if (this.running_count > 0 && !this._reload_done) {
// Case 1: was running this session, now stopped — one-time reload.
// _reload_done guards against multiple queued callbacks all firing
// reload before the first navigation clears the page.
this._reload_done = true;
window.location.reload();
} else if (!wu_thank_you.creating) {
// Case 2: PHP already reported creation complete — mark ready.
Expand Down
Loading