feat: command prompt for zephyr log#2865
Conversation
|
Works fine by me. One a bit distracting thing is those prompts that are inserted even in the middle of a command, e.g.: Not sure what to do with them though.
Anyways, this is good enough for me. |
|
Agent could echo the command, it is up to you @kareltucek or @mondalaci .
I kept it because I thought it is easier to resend the same command multiple times. You don't have to rush with the answer I am starting the developments on tomorrow afternoon or Friday morning |
|
I strongly prefer Agent-side echoing for responsiveness. I think firmware-side echoing is redundant. |
That's why I think we should consider a full vt100 terminal. As long as there is some javascript terminal emulator package out there, we get all these features for free and much more. |
70bd27e to
afbc9a5
Compare
kareltucek
left a comment
There was a problem hiding this comment.
Bump. Not sure what the state of affairs is, but would love to see this merged and pre-released so that the prompt is available when troubleshooting stuff with people.
Any improvements are welcome, but may as well be merged in later PRs ;-).
|
On this week I would like to improve it with v100 terminal and merge |
afbc9a5 to
79fde4c
Compare
|
@kareltucek Is the UltimateHackingKeyboard/firmware#1554 relevant firmware Pr? If yes then is it worth to rebase? I am starting the new implementation and my plan is to finish it today. |
79fde4c to
226cc1e
Compare

closes: #2812
It works with the bundled firmware. Shell command to test the function is
uhk connections