Skip to content

Introduce internal dataclass to restructure the craziest loop that ex…#470

Merged
cvanelteren merged 3 commits into
mainfrom
refactor-cartesian-crazy-loop
Jan 15, 2026
Merged

Introduce internal dataclass to restructure the craziest loop that ex…#470
cvanelteren merged 3 commits into
mainfrom
refactor-cartesian-crazy-loop

Conversation

@cvanelteren

@cvanelteren cvanelteren commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator

There was this insane loop in cartesian.py that was bothering me for a while now.

I replaced the loop with an internal config. No API changes for the enduser, just beter readability.

@cvanelteren cvanelteren enabled auto-merge (squash) January 15, 2026 07:09
@codecov

codecov Bot commented Jan 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.80851% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/axes/cartesian.py 96.80% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@cvanelteren cvanelteren disabled auto-merge January 15, 2026 07:29
@cvanelteren cvanelteren merged commit dec5c77 into main Jan 15, 2026
3 of 5 checks passed
@cvanelteren cvanelteren deleted the refactor-cartesian-crazy-loop branch January 15, 2026 07:30
K-Mirembe-Mercy pushed a commit to K-Mirembe-Mercy/UltraPlot that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant