Fix int/list has no size error, for bar plot of pd.Series#732
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
While this line would remove the error it does not fix the actual error. I think we can make this easier by doing some input validation. Will update this PR. |
Issue Ultraplot#731 reproduces because pandas dispatches Series.plot(kind="barh") with a scalar ``bottom`` (or ``left``), which flowed unchanged through ``_apply_bar``: ``_not_none(b, np.array([0.0]))`` returns the scalar as soon as it is not ``None``, then ``for y in (b, b + h)`` later passed it to ``_inbounds_xylim`` where ``x.size`` / ``y.size`` raised ``AttributeError`` for ints and lists. Normalize ``b`` to an ndarray once via ``np.atleast_1d`` so all downstream code sees an array, and restore the original ``x.size`` invariant in ``_inbounds_xylim`` (the defensive ``getattr`` only masked the symptom). Add a regression test exercising both direct scalar ``bottom``/``left`` and the original ``pd.Series.plot(kind="barh")`` reproducer.
cvanelteren
force-pushed
the
fix-inthasnosize
branch
from
cc9ca7d to
725d547
Compare
Collaborator
|
Thanks for all the work @gepcel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #731, wait for @cvanelteren