Integrate feedback from @Chman

Better name for RenderViewportScale value
Use ShaderIDs instead of raw string (hashing)

Author: robbiesri

PostProcessing/Runtime/PostProcessLayer.cs

@@ -275,11 +275,11 @@ void OnPreCull()
             if (m_Camera.stereoEnabled)
             {
                 m_Camera.ResetStereoProjectionMatrices();
-                Shader.SetGlobalFloat("rvsGlobal", XRSettings.renderViewportScale);
+                Shader.SetGlobalFloat(ShaderIDs.RenderViewportScaleFactor, XRSettings.renderViewportScale);
             }
             else
             {
-                Shader.SetGlobalFloat("rvsGlobal", 1.0f);
+                Shader.SetGlobalFloat(ShaderIDs.RenderViewportScaleFactor, 1.0f);
             }
 
             BuildCommandBuffers();

PostProcessing/Runtime/Utils/RuntimeUtilities.cs

@@ -205,7 +205,6 @@ public static void BlitFullscreenTriangle(Texture source, RenderTexture destinat
         // Assumes that both textures have the exact same type and format
         public static void CopyTexture(CommandBuffer cmd, RenderTargetIdentifier source, RenderTargetIdentifier destination)
         {
-            // TODO: Not sure if this works with texture arrays...
             if (SystemInfo.copyTextureSupport > CopyTextureSupport.None)
             {
                 cmd.CopyTexture(source, destination);

PostProcessing/Runtime/Utils/ShaderIDs.cs

@@ -144,5 +144,7 @@ static class ShaderIDs
         internal static readonly int WaveformSource                  = Shader.PropertyToID("_WaveformSource");
         internal static readonly int WaveformBuffer                  = Shader.PropertyToID("_WaveformBuffer");
         internal static readonly int VectorscopeBuffer               = Shader.PropertyToID("_VectorscopeBuffer");
+
+        internal static readonly int RenderViewportScaleFactor       = Shader.PropertyToID("_RenderViewportScaleFactor");
     }
 }

PostProcessing/Shaders/xRLib.hlsl

@@ -24,7 +24,7 @@ CBUFFER_START(UnityStereoEyeIndex)
 CBUFFER_END
 #endif
 
-float rvsGlobal;
+float _RenderViewportScaleFactor;
 
 float2 UnityStereoScreenSpaceUVAdjust(float2 uv, float4 scaleAndOffset)
 {
@@ -45,7 +45,7 @@ float2 UnityStereoClampScaleOffset(float2 uv, float4 scaleAndOffset)
 float2 TransformStereoScreenSpaceTex(float2 uv, float w)
 {
     float4 scaleOffset = unity_StereoScaleOffset[unity_StereoEyeIndex];
-    scaleOffset.xy *= rvsGlobal;
+    scaleOffset.xy *= _RenderViewportScaleFactor;
     return uv.xy * scaleOffset.xy + scaleOffset.zw * w;
 }
 
@@ -62,13 +62,13 @@ float4 UnityStereoTransformScreenSpaceTex(float4 uv)
 float2 UnityStereoClamp(float2 uv)
 {
     float4 scaleOffset = unity_StereoScaleOffset[unity_StereoEyeIndex];
-    scaleOffset.xy *= rvsGlobal;
+    scaleOffset.xy *= _RenderViewportScaleFactor;
     return UnityStereoClampScaleOffset(uv, scaleOffset);
 }
 #else
 float2 TransformStereoScreenSpaceTex(float2 uv, float w)
 {
-    return uv * rvsGlobal;
+    return uv * _RenderViewportScaleFactor;
 }
 
 float2 UnityStereoTransformScreenSpaceTex(float2 uv)
@@ -78,7 +78,7 @@ float2 UnityStereoTransformScreenSpaceTex(float2 uv)
 
 float2 UnityStereoClamp(float2 uv)
 {
-    float4 scaleOffset = float4(rvsGlobal, rvsGlobal, 0.f, 0.f);
+    float4 scaleOffset = float4(_RenderViewportScaleFactor, _RenderViewportScaleFactor, 0.f, 0.f);
     return UnityStereoClampScaleOffset(uv, scaleOffset);
 }
 #endif