Default Points of Arrival container_id to prod + drop unused Geddes header#64
Merged
Merged
Conversation
…eader. - config/collections/pointsofarrival.php now falls back to the prod community UUID (5f407bc8-…fac8e07c7f) instead of the dev UUID (bac433ed-…3fd0bed2c). We only read from Solr so prod data is the right default everywhere; dev/staging can override via POINTSOFARRIVAL_CONTAINER_ID. Brings POA in line with every other prefixed DSpace collection (alumni, art, geddes, openbooks, mimed, public-art, iog, etc.). - public/collections/geddes/images/n-header-doves.png: replace the oversized banner asset (24.4 KB → 17.1 KB) noticed while preparing the IOG PR. No visible change in the layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small alignment fixes spotted while reviewing the IOG migration (#63):
config/collections/pointsofarrival.phpnow falls back to the production community UUID5f407bc8-1f6c-4ab7-830a-66fac8e07c7finstead of the dev UUIDbac433ed-36a9-4660-b49c-49d3fd0bed2c. We only read from Solr and want live data by default everywhere; dev/staging can override viaPOINTSOFARRIVAL_CONTAINER_IDin.env. Brings POA in line with every other prefixed DSpace collection (alumni, art, geddes, mimed, openbooks, physics, public-art, iog, etc.)..env.exampleupdated with the matching guidance.public/collections/geddes/images/n-header-doves.pngre-exported at 17.1 KB (was 24.4 KB). No visible change in the rendered banner.Test plan
php artisan test --compact tests/Feature/PointsofarrivalCollectionTest.php→ 26 passed, 42 assertions.vendor/bin/pint --dirty --format agentpasses./pointsofarrival(prefix mode) and the dedicated host still surface live records after deploy (uses the prod UUID by default now, so should match production behaviour).Notes for reviewers
This depends on no other changes and can merge ahead of, or after, #63. If POA-specific dev/staging environments rely on the dev container they will need
POINTSOFARRIVAL_CONTAINER_ID=bac433ed-36a9-4660-b49c-49d3fd0bed2cin their.envbefore merge — the legacy dev UUID is recorded in.env.exampleas a hint.