-
Notifications
You must be signed in to change notification settings - Fork 16
Release: 2.26.2 #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.26.2 #203
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| val usercentricsVersion = "2.26.1" | ||
| val usercentricsVersion = "2.26.2" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [REFACTORING] You updated val usercentricsVersion = "2.26.2" (line 1). There are now two separate places holding the same SDK version (build-legacy.gradle and build.gradle.kts). Consider centralizing the SDK version (e.g., gradle.properties or rootProject ext property) to avoid future mismatches and accidental inconsistent bumps across build files. // android/build.gradle.kts
// Consider reading this from a shared property instead of hardcoding
val usercentricsVersion = project.findProperty("USERCENTRICS_SDK_VERSION") as String? ?: "2.26.2"
// android/build-legacy.gradle
// def usercentrics_version = USERCENTRICS_SDK_VERSION ?: "2.26.2"
def usercentrics_version = project.hasProperty('USERCENTRICS_SDK_VERSION') ? project.property('USERCENTRICS_SDK_VERSION') : "2.26.2"And in USERCENTRICS_SDK_VERSION=2.26.2 |
||
| val reactNativeVersion = "+" | ||
|
|
||
| fun BooleanProperty(name: String): Boolean { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[VALIDATION] You updated def usercentrics_version = "2.26.2" (line 1). Run a Gradle sync / full CI build to confirm the dependency resolution for com.usercentrics.sdk:usercentrics-ui:2.26.2 succeeds and there are no transitive or repository problems. Also search the repo for other occurrences of the legacy variable to ensure no stale references remain.