Skip to content

Added more NitroSDK labels, filled language addresses - #429

Merged
UsernameFodder merged 3 commits into
UsernameFodder:masterfrom
AnonymousRandomPerson:master
Oct 24, 2026
Merged

UsernameFodder merged 3 commits into
UsernameFodder:masterfrom
AnonymousRandomPerson:master

Conversation

@AnonymousRandomPerson

Copy link
Copy Markdown
Contributor

NitroSDK labels are sourced from the Pokémon Platinum decomp and were contributed by @CecilArmitais. Disclosure that the process of comparing functions between Platinum and EoS was assisted by Claude Opus 5; more details about the process can be found in the corresponding pmd-sky decomp PR. I verified independently that all symbols exist in Platinum (i.e., no hallucinated symbol names).

Some SDK symbols have been renamed without aliases. These symbols were originally misidentified, and are corrected in this PR.

@UsernameFodder UsernameFodder left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing non-placeholder symbols without adding aliases always needs to happen with a version bump in .github/workflows/release.yml. Let's set RELEASE_VERSION to 0.11.0 with this.

@UsernameFodder
UsernameFodder merged commit 86c5f93 into UsernameFodder:master Oct 24, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants