feat(settlement): implement round-half-up fee computation to prevent …#36
Merged
elizabetheonoja-art merged 2 commits intoJun 25, 2026
Conversation
…micro-settlement extraction
elizabetheonoja-art
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
PR Description
Summary
Implements round-half-up (commercial) rounding for protocol fee computation to close a systematic value extraction vector via micro-settlements.
Problem
The fee formula
fee = amount * fee_rate_bps / 10000uses integer division that always truncates. An attacker can submit millions of minimum-dust settlements (amount = 1 in 7-decimal fixed-point), causing every fee to truncate to 0 — extracting 100% of intended protocol fees.Solution
New
compute_feefunction incontracts/settlement/src/fees.rs: