Conversation
|
@JitpanuM Please let me know, once this is ready for review. So far the pre-commit CI check is still failing. |
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Add download and compile of reflection.proto for gRPC server reflection to deps.sh Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
…u and Debian Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
…y descriptor files fix pointer cast Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
ce61d77 to
6e7a07e
Compare
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
|
Ready for review now :) |
Signed-off-by: al3xa23 <140614263+al3xa23@users.noreply.github.com>
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
|
Hi @stv0g , the CI is building now. Can you make the review? What is missing from your side? |
|
@al3xa23 @JitpanuM Thanks for these contributions. I think its a really great addition :-) I will do a review in the coming days. I am wondering: Instead of adding a new node-type, cant we rebrand this node-type as v2 of the I would like to deprecate the older v1 Also, I believe Or has there been some reasoning why |
|
Hi @stv0g, we chose originally gateway because we want to support different API conversions/translations. However, if you think, it makes more sense to have it in one API node-type, we can change it of couse. |
|
I think it makes sense to just name it "api". As far as I understand, we are not talking about a standardized API here. Its rather a custom VILLASnode API available over some network transports (HTTP, gRPC, ...). For the existing node-type, its also the case. It was a failed attempt at creating a unfied API in the ERIGrid project. So I would like to get rid of this node-type to reduce the maintenance burden. As long as all these transport share the same foundation (methods, datatypes, ...) we should aggregate them in the same node-type. However, we also support other APIs like NGSI via the Going forward, I propose:
What do you think? I am interested in your ideas too :) |
Add new gateway node-type for transforming an api type comming to VILLASnode http server.
Currently it only support transformation of http and gRPC.
The protobuf payload that is not VILLASnode is also support using gRPC server reflection.
The gRPC server reflection feature is not available when install gRPC with package manager.
The additonal script is made to get the reflection.proto file from gRPC repo.