Skip to content

tech(useFocusVisible): refactor hook without AppRootContext#9686

Open
EldarMuhamethanov wants to merge 4 commits intomasterfrom
e.muhamethanov/refactor-use-focus-visible
Open

tech(useFocusVisible): refactor hook without AppRootContext#9686
EldarMuhamethanov wants to merge 4 commits intomasterfrom
e.muhamethanov/refactor-use-focus-visible

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

  • Unit-тесты
  • Release notes

Описание

Рефакторинг механизма focus-visible с отвязкой от AppRootContext: трекинг keyboard перенесен в useKeyboardInputTracker, а useFocusVisible больше не зависит от AppRoot.
Также упрощен AppRootContext (удалено поле keyboardInput) и обновлены тесты, которые раньше эмулировали keyboard input через контекст.

Release notes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

size-limit report 📦

Path Size
JS 409.62 KB (-0.01% 🔽)
JS (gzip) 125.63 KB (+0.05% 🔺)
JS (brotli) 103.56 KB (+0.01% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 374.58 KB (0%)
CSS (gzip) 46.15 KB (0%)
CSS (brotli) 36.59 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 9817e94

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9686/9817e94f1e211282f8ca37786df4c3c54d002f6a/pkg/@vkontakte/vkui/_pkg.tgz

Commit 9817e94

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.33%. Comparing base (b3bf4ce) to head (9817e94).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9686   +/-   ##
=======================================
  Coverage   95.32%   95.33%           
=======================================
  Files         439      439           
  Lines       12093    12105   +12     
  Branches     4401     4403    +2     
=======================================
+ Hits        11528    11540   +12     
  Misses        565      565           
Flag Coverage Δ
unittests 95.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inomdzhon inomdzhon moved this to 👀 In Review in VKUI Apr 15, 2026
@inomdzhon inomdzhon added this to the v8.2.0 milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In Review

Development

Successfully merging this pull request may close these issues.

2 participants