Skip to content

refactor: break message verification handling out into free function #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidsteiner merged 6 commits into from
Mar 21, 2026

Move handle_verification_failure out of session

aa5cb67
Select commit
Loading
Failed to load commit list.
Merged

refactor: break message verification handling out into free function #324

Move handle_verification_failure out of session
aa5cb67
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2026 in 0s

91.06% (+0.10%) compared to 1aaf9d8

View this Pull Request on Codecov

91.06% (+0.10%) compared to 1aaf9d8

Details

Codecov Report

❌ Patch coverage is 93.70861% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.06%. Comparing base (1aaf9d8) to head (aa5cb67).

Files with missing lines Patch % Lines
crates/hotfix/src/session/state/awaiting_resend.rs 85.10% 7 Missing ⚠️
crates/hotfix/src/session.rs 87.50% 6 Missing ⚠️
crates/hotfix/src/session/state/awaiting_logout.rs 80.00% 4 Missing ⚠️
crates/hotfix/src/session/state.rs 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   90.95%   91.06%   +0.10%     
==========================================
  Files          92       94       +2     
  Lines        9157     9232      +75     
==========================================
+ Hits         8329     8407      +78     
+ Misses        828      825       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov