Conversation
This reverts commit 6353143.
- PreserveNewest for all 3D model files: Avoids copying hundreds of unchanged files every build. - TieredCompilationQuickJitForLoops set to True for faster startup. - GarbageCollectionAdaptationMode set to 0 to avoid GC scale-up stall when the app goes from idle to active.
* Early WIP * More work * More work on FindAvailableDeviceId * More work * more work * Implemented: MountDevice and DismountDevice * Add missing enums * Code cleanup * tentative: add rumble support * Fixed an issue causing UI freeze when SDL controller GameType couldn't be pulled * UI: Implement UI navigation debouncing * code cleanup * UI: Add a few quick buttons to ProfilesPage * build 0.28.6.0 (vJoy) Fixed an issue with vJoy SDL mapping * UI: Improved Library artwork refresh logic * build 0.28.6.1
…n toggle was enabled
* UI: Attempting to make it faster * More work * UI: Misc tweaks * UI: Fixed WindowState logic * UI: Misc tweaks * More work on smaller optimizations * UI: Reduce overhead when creating hotkeys * UI: Migrate Hotkey settings to a dedicated page * UIGamepad: Improve history logic * UI: Improve caching logic for Library * UI: Improve navigation focus and button/text logic * Library: SDL3-CS (3.4.2) * Update MainWindow.xaml.cs * UI: Improve gamepad navigation When the focused control lives inside a scrollViewer, controls sharing that same scrollViewer ancestor are considered first. * UI: Fixed an issue with Hotkey chord listening ToggleButton * UI: UI: Fixed an issue with Hotkey chord listening ToggleButton (proper) * UI: Improved UIGamepad IsEnabled, IsVisible check logic * UI: Fixed an issue causing a crash when Library index is OutOfRange * UI: Improve Library ContentDialog ViewModel logic * build 0.28.6.2 * Memory leak: Fixed LibreHardwarePlatform * UI: Improve profiles page(s) behavior * Misc optimizations * Misc work * Update ProfileViewModel.cs * Fix binding error * UI: Asynchronously display games * UI: Add play button on mouse hover * Add new ViewMode: All Wide * UI: Toggle Play/Stop button on mouse hover * build 0.28.6.3 * Add GameControllerDB download during post-install setup (#514) * Installer: download gamecontrollerdb.txt to install dir Adds a CurStepChanged(ssPostInstall) handler that fetches the latest gamecontrollerdb.txt from SDL_GameControllerDB master branch and places it at the root of the install folder ({app}\gamecontrollerdb.txt). https://claude.ai/code/session_014L6Fi571YpvKtvBhExibhZ * Remove bundled gamecontrollerdb.txt, now fetched by installer The installer downloads the latest gamecontrollerdb.txt from SDL_GameControllerDB at install time, so the file no longer needs to be shipped in the repo or copied via the build output. https://claude.ai/code/session_014L6Fi571YpvKtvBhExibhZ --------- Co-authored-by: Claude <noreply@anthropic.com> * Fixed an issue with SDL controller glyph pulling * Show descriptive message while downloading gamecontrollerdb * build 0.28.6.4 --------- Co-authored-by: Claude <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (134)
📝 WalkthroughWalkthroughThis large-scope pull request introduces vJoy virtual controller support with DInput mode, implements gyro velocity-based scaling, redesigns the library UI with view modes and artwork handling, refactors multiple manager classes for improved synchronization and lifecycle management, and updates device-specific sensor configurations. Substantial changes span installers, core actions, device support, managers, converters, UI components, ViewModels, and localization resources. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
💡 Codex Review Read GPU monitor preference instead of hardcoding true
Target Copilot window with a unique automation filter
The command identifies Copilot using only the class name ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes