-
Notifications
You must be signed in to change notification settings - Fork 104
Fix import side effect #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a81cd1
Fix import side effect by using lazy initialization
fcogidi dba967e
Add extra configuration option to ignore unknown environment variables
fcogidi 99f471c
Bump version of aieng-agents to 0.1.1
fcogidi 0d90a0a
Merge branch 'main' into fco/fix_import_side_effect
fcogidi 30b2519
Remove bare import
fcogidi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,48 @@ | ||
| """Shared instance of langfuse client.""" | ||
|
|
||
| from functools import cached_property | ||
|
|
||
| from aieng.agents.env_vars import Configs | ||
| from langfuse import Langfuse | ||
| from rich.progress import Progress, SpinnerColumn, TextColumn | ||
|
|
||
|
|
||
| __all__ = ["flush_langfuse", "langfuse_client"] | ||
| class _LangfuseClientManager: | ||
| @cached_property | ||
| def config(self) -> Configs: | ||
| return Configs() | ||
|
|
||
| @cached_property | ||
| def client(self) -> Langfuse: | ||
| return Langfuse( | ||
| public_key=self.config.langfuse_public_key, | ||
| secret_key=self.config.langfuse_secret_key, | ||
| ) | ||
|
|
||
|
|
||
| _manager = _LangfuseClientManager() | ||
| langfuse_client: Langfuse # noqa: F822 -- lazily initialized via __getattr__ | ||
|
|
||
| config = Configs() | ||
| langfuse_client = Langfuse( | ||
| public_key=config.langfuse_public_key, secret_key=config.langfuse_secret_key | ||
| ) | ||
|
|
||
| def __getattr__(name: str) -> Langfuse: | ||
| """Module-level lazy loading for backward compatibility.""" | ||
| if name == "langfuse_client": | ||
| return _manager.client | ||
| raise AttributeError(f"module has no attribute '{name}'") | ||
|
|
||
| def flush_langfuse(client: "Langfuse | None" = None) -> None: | ||
|
|
||
| def flush_langfuse(client: Langfuse | None = None) -> None: | ||
| """Flush shared LangFuse Client. Rich Progress included.""" | ||
| if client is None: | ||
| client = langfuse_client | ||
| client = _manager.client | ||
|
|
||
| with Progress( | ||
| SpinnerColumn(), | ||
| TextColumn("[progress.description]{task.description}"), | ||
| transient=True, | ||
| ) as progress: | ||
| progress.add_task("Finalizing Langfuse annotations...", total=None) | ||
| langfuse_client.flush() | ||
| client.flush() | ||
|
|
||
|
|
||
| __all__ = ["flush_langfuse", "langfuse_client"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.