Skip to content

🥢 Fix typos in FixedPointMathLib.sol#1539

Open
BhariGowda wants to merge 1 commit into
Vectorized:mainfrom
BhariGowda:fix/natspec-typos
Open

🥢 Fix typos in FixedPointMathLib.sol#1539
BhariGowda wants to merge 1 commit into
Vectorized:mainfrom
BhariGowda:fix/natspec-typos

Conversation

@BhariGowda

Copy link
Copy Markdown
Contributor

Fix two NatSpec comment typos in FixedPointMathLib.sol:

  1. begins == endbegin == end in both lerp() overloads
    (parameter is named begin, not begins)

  2. Fix broken comment line split in mulDiv inverse computation

@github-actions

Copy link
Copy Markdown

Gas Snapshot Comparison Report

Generated at commit : fd81365, Compared to commit : ab96a83

Contract Name Test Name Main Gas PR Gas Diff
LibRLPWithCLZTest testComputeAddressForLargeNonces() 1750 - -
testComputeAddressForSmallNonces() 997 - -
testComputeAddressOriginalForLargeNonces() 3495 - -
testComputeAddressOriginalForSmallNonces() 2088 - -
testRLPEncodeBytes() 250090 - -
testRLPEncodeBytes2() 155904 - -
testRLPEncodeList() 735942 - -
testRLPEncodeList2() 810708 - -
testRLPEncodeListEdgeCases() 1807743 - -
testRLPEncodeStringEdgeCases() 20424 - -
testRLPEncodeUint() 1175570 - -
testRLPPUint256() 363834 - -
test__codesize() 18292 - -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant