fix(build): inline hexColors in index.js for browser bundler compatibility#25
Open
fix(build): inline hexColors in index.js for browser bundler compatibility#25
Conversation
…ility The JS entry previously read hex/colors.json at runtime via node:fs, which fails in browser-targeted bundlers (Webpack, Vite browser, Remotion) with: UnhandledSchemeError: Reading from "node:fs" is not handled by plugins. Now the build inlines the JSON values directly into index.js at build time, so @verdigristech/design-tokens works in any environment — Node, SSR, Vite, Webpack, Remotion — without runtime filesystem access. Public API unchanged: `hexColors: Record<string, string>`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The JS entry (`build/dist/index.js`) previously read `hex/colors.json` at runtime via `node:fs`, which fails in any browser-targeted bundler — Webpack, Vite (browser), Remotion — with:
```
UnhandledSchemeError: Reading from "node:fs" is not handled by plugins.
```
This blocks consuming `hexColors` from the Remotion scaffold in verdigristech/verdigris (Z2O-1029).
Fix
Inline the hex values directly into `index.js` at build time. No runtime filesystem dependency, so the package works everywhere: Node, SSR, Vite, Webpack, Remotion.
Public API
Unchanged. `hexColors` is still exported as `Record<string, string>`, same keys, same values.
Test plan