fix: implement per-validator rate limit in slashing mempool#28
Merged
Conversation
Contributor
|
CI failed |
Author
|
Fixed |
…placing std usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
fix: implement per-validator rate limit in slashing mempool
Description
What was done
HashMap<ValidatorIndex, u8>rate-limiter to theSlashingMempool.MAX_EVIDENCE_PER_VALIDATOR_PER_EPOCH = 1.push_evidence()to immediately return anOverflowErrorand drop any redundant evidence for the same validator.reset_epoch()to clear the rate-limit map at epoch boundaries.slashingmodule into the Soroban environment securely via#![cfg_attr(target_family = "wasm", no_std)].Why it was done
How it was verified
cargo test --test griefing_resistance_test.test_minimal_evidence_flood_griefing_resistance) that actively pushes 100 duplicate evidence entries for the same validator index, verifying that exactly 1 is successfully accepted while the remaining 99 are immediately rejected with anOverflowError::RateLimitReached.Closes #25