Feature/committee reorg fix#47
Merged
JamesEjembi merged 7 commits intoJun 25, 2026
Merged
Conversation
added 7 commits
June 25, 2026 08:41
This commit resolves the issue where attestation verification fails spuriously when validator sets are dynamically reorganized mid-epoch due to irregular exits or late-inclusion activations. Key Changes: - Added committee_assignment.rs: Tracks committee state with reorg support - PendingReorg: Records reorg time windows - CommitteeView: Represents stable or ambiguous committee state - CommitteeAssignment: Manages validator indices and committee roots - Added db/committee_cache.rs: Caches committee roots with reorg support - Stores both stable and ambiguous entries - Auto-evicts old entries based on capacity - Supports smooth transition from ambiguous to stable - Enhanced validator_set.rs: Added reorg tracking and active validator queries - Enhanced attestation/verifier.rs: Added committee-view-aware verification - verify_attestation_with_committee_view: Accepts ambiguous views - Attestations verify against either old or new root during reorg window - Added comprehensive integration tests (11 tests covering all scenarios) Test Results: - All 32 unit tests pass - All 11 new integration tests pass - All 163 total tests pass - Zero regressions The fix ensures cross-boundary attestations are verifiable under both pre-reorg and post-reorg committee roots during a 4-slot reorg window, then automatically finalizes to a stable state.
JamesEjembi
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8