fix(stoa-vitals): repair boot-time plugin install failure#140
Merged
Conversation
Three fixes for the "plugin install error at startup" report: 1. install.sh never symlinked stoa-vitals into ~/.config/noctalia/plugins/ (the other three Stoa plugins were linked, this one was missed). With the plugin enabled in plugins.json but absent on disk, Noctalia's plugin manager tried to download it at boot and failed. 2. plugins.json pointed every stoa-* plugin at the noctalia-dev community repo, where none of them exist — any update check against that source errors. They now point at the Stoa Linux source already declared in "sources". 3. Panel.qml sized itself via stack.currentItem, which is StackView API — StackLayout has no such property, so the panel height silently broke. Index children[] by the active tab instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "plugin install error at boot" reported after #138 merged. Three distinct bugs, one root cause each:
1. Missing symlink (the actual install error)
install.shlinksstoa-memento,stoa-doctor-pillandstoa-drive-pillinto~/.config/noctalia/plugins/, but the equivalent line forstoa-vitalswas never added. With the plugin markedenabled: trueinplugins.jsonbut absent on disk, Noctalia's plugin manager tries to download it at startup — and fails, because…2. Wrong
sourceUrlfor everystoa-*pluginAll four Stoa plugins pointed at
https://github.com/noctalia-dev/noctalia-plugins, where none of them exist. Any install or update check against that source errors out. They now point at the Stoa Linux source already declared in thesourcesarray. This also explains why the doctor pill itself could throw install errors at boot before this PR.3.
stack.currentItemis not StackLayout APIPanel.qmlsized itself withstack.currentItem.implicitHeight— that property belongs toStackView;StackLayoutdoesn't have it, so the panel height binding silently failed. Replaced withstack.children[currentTab].implicitHeight(guarded).Test plan
install.sh; confirm~/.config/noctalia/plugins/stoa-vitalssymlink existshttps://claude.ai/code/session_01NS2BA7fzvSsp3ZhPzU18fL
Generated by Claude Code