fix agentTokenV3._autoswap() uniswap invalidTo error#154
Closed
koo-virtuals wants to merge 2 commits intomainfrom
Closed
fix agentTokenV3._autoswap() uniswap invalidTo error#154koo-virtuals wants to merge 2 commits intomainfrom
koo-virtuals wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 69f1890. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes the on-chain tax autoswap path for
AgentTokenV3by introducing a new adapter contract and additional approvals/external calls; misconfiguration (unset adapter) or integration issues with routers/tax recipients could block autoswaps or leave funds temporarily held on the adapter.Overview
Fixes
AgentTokenV3autoswap failures caused by Uniswap V2 pairINVALID_TOby routing tax swaps through a new upgradeableTaxAccountingAdapterthat receives swap output and then callsdepositTaxon the tax recipient.AgentTokenV3._swapTaxnow requirestaxAccountingAdapterto be set, delegates swap+deposit to the adapter (with allowance reset), and factors the pending-tax accounting into a helper. The Uniswap router mock was enhanced to actually move tokens forswapExactTokensForTokensSupportingFeeOnTransferTokens, and tests were refactored/extended with a shared fixture plus a new E2E suite covering adapter-based autoswap +depositTaxattribution.Reviewed by Cursor Bugbot for commit 26f8632. Bugbot is set up for automated code reviews on this repo. Configure here.