Repository navigation
refactor(headers): reorganize header placement by subsystem - #116
Merged
Merged
Conversation
Move headers out of include/kernel now that their ownership is clear: errno.h -> include/libs/std/errno.h writer.h -> include/libs/util/writer.h ioctl.h -> include/syscall/ioctl.h termios.h -> include/drivers/tty/termios.h printk.h -> include/kernel/debug/printk.h vsprintf.h -> include/kernel/debug/vsprintf.h Update every include site and sort the leading include blocks of the affected files. Move the scheduler steal-budget assertion below the header's initial constant as a small ordering cleanup. Split ioctl command definitions from the request-number encoding: syscall/ioctl.h keeps only the _IOC/_IO* machinery, while the new syscall/ioctls.h holds the generic file/descriptor commands (FIONREAD, FIONBIO, FIONCLEX, FIOCLEX, FIOASYNC and FIOQSIZE). termios.h includes the command header and keeps TIOCINQ as the TTY alias for FIONREAD; pipe, inotify and process include the generic header directly, while rtc, ppdev, evdev, drm and seccomp keep the encoding-only header. No functional change. Validation: clean GCC LTO build; git diff --check. Signed-off-by: MicroFish <2609948707@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move headers out of include/kernel now that their ownership is clear:
errno.h -> include/libs/std/errno.h
writer.h -> include/libs/util/writer.h
ioctl.h -> include/syscall/ioctl.h
termios.h -> include/drivers/tty/termios.h
printk.h -> include/kernel/debug/printk.h
vsprintf.h -> include/kernel/debug/vsprintf.h
Update every include site and sort the leading include blocks of the affected files. Move the scheduler steal-budget assertion below the header's initial constant as a small ordering cleanup.
Split ioctl command definitions from the request-number encoding: syscall/ioctl.h keeps only the _IOC/_IO* machinery, while the new syscall/ioctls.h holds the generic file/descriptor commands (FIONREAD, FIONBIO, FIONCLEX, FIOCLEX, FIOASYNC and FIOQSIZE). termios.h includes the command header and keeps TIOCINQ as the TTY alias for FIONREAD; pipe, inotify and process include the generic header directly, while rtc, ppdev, evdev, drm and seccomp keep the encoding-only header.
No functional change.
Validation: clean GCC LTO build; git diff --check.