fix(client): improve request failure diagnostics#109
Open
Vizards wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves DeepSeek client failure diagnostics by attaching request context (base URL + request shape metadata) to HTTP/network errors and emitting a compact, readable first-line summary with the raw stack beneath it.
Changes:
- Introduces a
RequestErrorContexttype to carry base URL + request details into error handling. - Enhances HTTP and network error diagnostic strings to include request metadata (model, stream, tool/message counts, etc.) and safer single-line serialization.
- Updates client logging to emit a single formatted diagnostic+stack string via
formatRequestError.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/client/types.ts | Adds RequestErrorContext to pass request/baseUrl context into error formatting. |
| src/client/error.ts | Extends diagnostic formatting for HTTP/network/unknown errors and adds formatRequestError. |
| src/client/core.ts | Passes request context into error creation/normalization and updates logging to use the new formatter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run compilenpm run format:checknpm run lintgit diff --check