fix(verifier): keyboard shortcut overlay visible on load, Esc no-op#57
Merged
Conversation
The overlay's `#shortcut-overlay { display: flex }` rule had higher specificity than the UA `[hidden] { display: none }` rule, so the HTML `hidden` attribute on the overlay div had no visual effect. The overlay showed on every reload and the JS toggle paths (Esc, ?, backdrop click) silently flipped the attribute without changing what the user saw.
Scoping the layout block to `#shortcut-overlay:not([hidden])` lets the UA rule take over when hidden is set.
Closes #56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The keyboard-shortcut overlay was visible on every page load and could not be dismissed. CSS
#shortcut-overlay { display: flex }had higher specificity than the UA[hidden]rule, so thehiddenattribute on the overlay div was a no-op and the JS toggle paths (Esc,?, backdrop click) silently flipped a useless attribute.Scoping the layout block to
#shortcut-overlay:not([hidden])lets the UAdisplay: noneapply when hidden is set.Test plan
/verifier/(index mode) — overlay not visible./verifier/?bundle=…(edit mode) — overlay not visible.?— overlay opens.Esc— overlay closes.?to reopen, then click the dimmed backdrop — overlay closes.Closes #56