ci: bump actions/upload-pages-artifact to v5 (transitive node20 → node24)#176
Merged
Merged
Conversation
actions/upload-pages-artifact@v4 is a composite that internally pins actions/upload-artifact@v4.6.2, which runs on node20. The PR #174 post-merge deploy run flagged this in the annotation log. v5.0.0 bumps the internal artifact-action to v7.0.0 (node24); its public output contract (artifact_id, artifact_url) is unchanged. Closes #175.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
actions/upload-pages-artifact@v4→@v5in.github/workflows/nextjs.yml:90. This is the third and finalnode20-dependent action pin in the website's workflows, surfaced as a transitive annotation in #174's post-merge deploy run.Verification
upload-pages-artifact@v4(composite) → internallyupload-artifact@v4.6.2(node20)upload-pages-artifact@v5.0.0(composite) → internallyupload-artifact@v7.0.0(node24)artifact_id,artifact_url)include-hidden-filesinputThe website only consumes
upload-pages-artifact's outputs (passed downstream todeploy-pagesby name), so theupload-artifact@v4 → @v7internal jump is invisible at the workflow surface.Closes #175.
Test plan
Test build (pr-open)) runs green.nextjs.ymlbuildjob'sUpload artifactstep completes and thedeployjob pulls + deploys the artifact successfully.Node.js 20deprecation warning lines remain in the post-merge deploy run log (the success criterion this PR is trying to satisfy).