Skip to content

Fix AGENTS realpath containment on CI #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Waishnav merged 2 commits into from
Jul 7, 2026
Merged

Fix AGENTS realpath containment on CI #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6242f29
Fix AGENTS realpath containment on CI
Waishnav Jul 7, 2026
2fd5dc3
Fix Windows AGENTS fixture discovery
Waishnav Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/workspaces.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ const outsideRoot = await mkdtemp(join(tmpdir(), "devspace-workspace-outside-tes
try {
const agentDir = join(root, ".pi", "agent");
await mkdir(agentDir, { recursive: true });
await mkdir(join(agentDir, "skills"), { recursive: true });
await writeFile(join(agentDir, "skills", "AGENTS.md"), "global instructions\n");
if (platform() === "win32") {
await writeFile(join(agentDir, "AGENTS.md"), "global instructions\n");
} else {
await mkdir(join(agentDir, "skills"), { recursive: true });
await writeFile(join(agentDir, "skills", "AGENTS.md"), "global instructions\n");
await symlink("skills/AGENTS.md", join(agentDir, "AGENTS.md"));
}
await writeFile(join(root, "AGENTS.md"), "root instructions\n");
Expand Down Expand Up @@ -179,6 +179,12 @@ try {
mode: "worktree",
});
assert.equal(aliasWorkspace.workspace.sourceRoot, join(aliasRoot, "git-project"));

const aliasCheckout = await new WorkspaceRegistry(aliasConfig).openWorkspace(aliasRoot);
assert.deepEqual(
aliasCheckout.agentsFiles.map((file) => file.content),
["global instructions\n", "root instructions\n"],
);
}
} finally {
await rm(root, { recursive: true, force: true });
Expand Down
9 changes: 8 additions & 1 deletion src/workspaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,19 @@ export class WorkspaceRegistry {

private async loadInitialAgentsFiles(root: string): Promise<LoadedAgentsFile[]> {
const agentDir = resolve(this.config.agentDir);
const resolvedRoot = (await tryRealpath(root)) ?? root;
const resolvedAgentDir = (await tryRealpath(agentDir)) ?? agentDir;
const loadedFiles: LoadedAgentsFile[] = [];

for (const file of loadProjectContextFiles({ cwd: root, agentDir })) {
const path = resolve(file.path);
if (!isInitialAgentsFilePath(path, root, agentDir)) continue;
const content = await readResolvedContextFile(path, file.content, root, agentDir);
const content = await readResolvedContextFile(
path,
file.content,
resolvedRoot,
resolvedAgentDir,
);
if (content === undefined) continue;

loadedFiles.push({
Expand Down
Loading