Refactor inventory item comparison and cleanup#180
Closed
Rico-Rodriguez wants to merge 1 commit into
Closed
Conversation
Refactor item comparison to use SameText for case-insensitivity and remove redundant bank deposit loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor item comparison to use SameText for case-insensitivity and remove redundant bank deposit loop.
Fix 1:
Allow case-insensitive comparisons for items.
Fix 2:
Fix to allow withdrawing actual diff of items.
For example:
Before fix:
Open bank -> deposit 12 karambwans -> withdraw 13 karambwans.
After fix:
Open bank -> withdraw 1 karambwan