Skip to content

All missing stubs, refactor, build warnings, backwards compatibility.#40

Open
olivi-r wants to merge 23 commits into
Weather-OS:masterfrom
olivi-r:idl-refactor
Open

All missing stubs, refactor, build warnings, backwards compatibility.#40
olivi-r wants to merge 23 commits into
Weather-OS:masterfrom
olivi-r:idl-refactor

Conversation

@olivi-r
Copy link
Copy Markdown
Contributor

@olivi-r olivi-r commented Apr 5, 2026

Changes:

  • Add stubs for all public methods
  • Fix idl definition of IXSystemImpl
  • Convert IXThreadingImpl and IXNetworkingImpl to idl definitions
  • Fix build warnings, including 32-bit build
  • Fix signatures for a couple of incorrect methods
  • Interface inheritance for full backwards compatibility up to April 2026 release of GDK
  • Remove unused IWineAsyncWorkImpl interface
  • Sort Makefile.in sources to appease tools/make_makefiles
  • Fix E_POINTER being thrown by XSystemGetConsoleId and XSystemGetXboxLiveSandboxId when missing their optional Used arguments (also found independantly by @ChristopherHX)
  • Supersedes xgameprotocol: add stubs #31 and XLauncher Implementation #37
  • Tests for the various interface ids (marked flaky to pass on old xgameruntime.dll)

Stubs for XUser are included here, but the actual implementation is in #33

Areas that could be improved:

  • XPackageMount isn't stubbed due to inconsistent behaviour which sometimes calls the padding function on XError which is unclear if its the intended location or taking a shortcut to raising errors via private method, given that the method is deprecated.
  • XGameStreaming, XGameUi and XPackage likely have additional interface iids used before the first public tag of GDK, games made with older non-public versions that haven't been updated could have limited compatibility

@olivi-r olivi-r force-pushed the idl-refactor branch 3 times, most recently from 0c32cf8 to 63ec7cd Compare April 28, 2026 22:55
@olivi-r olivi-r force-pushed the idl-refactor branch 2 times, most recently from 0323e0d to 958a514 Compare May 18, 2026 06:24
@olivi-r
Copy link
Copy Markdown
Contributor Author

olivi-r commented May 18, 2026

This should be complete now, but I can make further changes if you would like.

@olivi-r olivi-r changed the title Fix build warnings, refactor XThreading and XNetworking Fix build warnings, refactor XNetworking, XSystem & XThreading May 18, 2026
@olivi-r olivi-r changed the title Fix build warnings, refactor XNetworking, XSystem & XThreading Build warnings, backwards compatibility, interface refactor. May 18, 2026
@RaphyTwin
Copy link
Copy Markdown

nice

@olivi-r olivi-r marked this pull request as draft May 25, 2026 22:33
@olivi-r olivi-r marked this pull request as ready for review May 26, 2026 10:01
@olivi-r olivi-r changed the title Build warnings, backwards compatibility, interface refactor. All missing stubs, refactor, build warnings, backwards compatibility. May 26, 2026
@olivi-r olivi-r mentioned this pull request May 26, 2026
@olivi-r
Copy link
Copy Markdown
Contributor Author

olivi-r commented May 28, 2026

Removed some left over static lib declarations

@LukasPAH LukasPAH mentioned this pull request May 28, 2026
@olivi-r olivi-r mentioned this pull request May 29, 2026
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants