All missing stubs, refactor, build warnings, backwards compatibility.#40
Open
olivi-r wants to merge 23 commits into
Open
All missing stubs, refactor, build warnings, backwards compatibility.#40olivi-r wants to merge 23 commits into
olivi-r wants to merge 23 commits into
Conversation
0c32cf8 to
63ec7cd
Compare
0323e0d to
958a514
Compare
Contributor
Author
|
This should be complete now, but I can make further changes if you would like. |
|
nice |
Closed
(cherry picked from commit 361abf3) Co-authored-by: Olivia Ryan <olivia.r.dev@gmail.com>
Contributor
Author
|
Removed some left over static lib declarations |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
IXSystemImplIXThreadingImplandIXNetworkingImplto idl definitionsIWineAsyncWorkImplinterfacetools/make_makefilesE_POINTERbeing thrown byXSystemGetConsoleIdandXSystemGetXboxLiveSandboxIdwhen missing their optionalUsedarguments (also found independantly by @ChristopherHX)xgameruntime.dll)Stubs for XUser are included here, but the actual implementation is in #33
Areas that could be improved:
XPackageMountisn't stubbed due to inconsistent behaviour which sometimes calls the padding function onXErrorwhich is unclear if its the intended location or taking a shortcut to raising errors via private method, given that the method is deprecated.XGameStreaming,XGameUiandXPackagelikely have additional interface iids used before the first public tag of GDK, games made with older non-public versions that haven't been updated could have limited compatibility