[wasm-split] Don't split trapping globals#8742
Open
aheejin wants to merge 1 commit into
Open
Conversation
Trapping globals, which became possible with the custom-descriptor proposal, should stay in the primary module because we have to preserve their trapping behavior upon instantiation. Also,note that we remove unused globals here: https://github.com/WebAssembly/binaryen/blob/17a90787bae4f4544e25b3e7833da076e0d543de/src/ir/module-splitting.cpp#L896-L903 But trapping globals shouldn't be removed even when they are unused to preserve the trapping behavior. In case someone wants to split modules assuming traps never happen, this also adds `--traps-never-happen` option to wasm-split, in which case we can freely split or remove trapping globals.
tlively
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trapping globals, which became possible with the custom-descriptor proposal, should stay in the primary module because we have to preserve their trapping behavior upon instantiation.
Also, note that we remove unused globals here:
binaryen/src/ir/module-splitting.cpp
Lines 896 to 903 in 17a9078
But trapping globals shouldn't be removed even when they are unused to preserve the trapping behavior.
In case someone wants to split modules assuming traps never happen, this also adds
--traps-never-happenoption to wasm-split, in which case we can freely split or remove trapping globals.