[NFC] ConstraintAnalysis: Track relevant locals#8921
Open
kripken wants to merge 20 commits into
Open
Conversation
tlively
reviewed
Jul 20, 2026
| // to is relevant as well. We store pairs here of key=source, value=targets. | ||
| std::unordered_map<Index, std::vector<Index>> localCopyTargets; | ||
|
|
||
| void markRelevant(Expression* curr) { |
Member
There was a problem hiding this comment.
Suggested change
| void markRelevant(Expression* curr) { | |
| void maybeMarkRelevant(Expression* curr) { |
Since this does not unconditionally mark the expression relevant.
Comment on lines
+90
to
+92
| // Track local copies too, as if one local is relevant, another it is copied | ||
| // to is relevant as well. We store pairs here of key=source, value=targets. | ||
| std::unordered_map<Index, std::vector<Index>> localCopyTargets; |
Member
There was a problem hiding this comment.
Shouldn't we be propagating relevance backward from copy destination to copy source? If I have a local $x whose value is never set or compared to anything, then it is copied to relevant $y, then I want to have that initial $x = 0 constraint. In contrast, if I have relevant $y and it is copied to irrelevant $z, then there is no need to consider $z relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By avoiding work on irrelevant locals - ones we can't prove anything for -
we make the pass 20% faster.