feat(android): add galleryImportAllowed option to scanDocument#178
Open
IshuKaur wants to merge 1 commit into
Open
feat(android): add galleryImportAllowed option to scanDocument#178IshuKaur wants to merge 1 commit into
IshuKaur wants to merge 1 commit into
Conversation
Adds a new `galleryImportAllowed` boolean option that lets users import images from the device gallery in addition to capturing with the camera. Wires through to GmsDocumentScannerOptions.setGalleryImportAllowed(). Defaults to false to preserve existing behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently the document scanner only allows capturing images via camera.
There is no way to import existing images from the device gallery.
Solution
Adds a new
galleryImportAllowedboolean option toscanDocument.When set to
true, the Google ML Kit scanner shows a gallery importbutton alongside the camera, allowing users to pick existing images
from their device.
Changes
src/NativeDocumentScanner.ts— addsgalleryImportAllowed?: booleanto
ScanDocumentOptionsinterface with JSDocandroid/src/main/java/com/documentscanner/DocumentScannerModule.kt—reads the option and passes it to
GmsDocumentScannerOptions.setGalleryImportAllowed()Usage