Skip to content

Add support for quoted filenames in mtllib entries #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sakai-san wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for quoted filenames in mtllib entries #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/OBJFile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,15 @@ class OBJFile {
for (let i = 0; i < lines.length; i += 1) {
const line = _stripComments(lines[i]);

const lineItems = line.replace(/\s+/g, ' ').trim().split(' ');
// splitting by blanks. For mtllib entry, balanced quote (single or double) around referreed file is stripped and file name having blanks is supported.
let lineItems;
let mtllibMatch = line.match(/^\s*(mtllib)\s+(['"]?)(.*?)\2\s*$/i);

if (mtllibMatch) {
lineItems = [mtllibMatch[1].toLowerCase(), mtllibMatch[3]];
} else {
lineItems = line.replace(/\s+/g, ' ').trim().split(' ');
}

switch (lineItems[0].toLowerCase()) {
case 'o': // Start A New Model
Expand Down