Conversation
# Conflicts: # src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformService.java # src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java # src/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/PlatformController.java
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
워크스루플랫폼 계정 연동 해제 기능을 완성합니다. 사용자 요청 기반 수동 해제(권한·소속 검증) 및 매일 자동 정리(스케줄러), 그리고 회원 탈퇴 시 플랫폼 연동 자동 해제까지 전체 파이프라인을 구현하여, ClickLog/MetricFact/관계 엔티티의 일관된 정리를 보장합니다. 변경사항플랫폼 계정 연동 해제 데이터 정리
예상 코드 리뷰 노력🎯 4 (Complex) | ⏱️ ~60분 이 PR은 배치 삭제 최적화, 트랜잭션 전파 제어, 계정 단위 예외 격리, 다층 검증 로직이 조합된 복합적인 변경입니다. 특히 PlatformDataCleanupExecutor의 REQUIRES_NEW 트랜잭션 격리, ClickLog 네이티브 SQL 조인 경로 검증, 회원 탈퇴 시 플랫폼 정리 선행 흐름, 스케줄러의 계정 단위 예외 처리 등을 꼼꼼히 검토해야 합니다. 관련된 PR
제안 리뷰어
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java (1)
152-183: 부분 실패 시 데이터 정합성에 대한 안내/대비를 권장합니다.
NOT_SUPPORTED로 전체를 하나의 트랜잭션으로 묶지 않기 때문에, 예를 들어 ClickLog·MetricFact 청크는 지워졌는데deleteAccountAndRelations단계에서 예외가 나면 "지표는 사라졌지만 계정/캠페인은 남아 있는" 중간 상태가 그대로 커밋된 채로 남습니다.다행히 청크 삭제와 검증 로직이 멱등에 가까워 동일 요청을 재시도하면 복구되는 구조이긴 합니다. 다만 운영 관점에서:
- 실패 시 재시도가 안전하다는 점을 로그/문서에 남기고,
- 알림(모니터링)으로 중간 실패를 잡을 수 있게 해두면
장애 상황에서 데이터가 어중간하게 남는 것을 빠르게 인지·복구할 수 있습니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java` around lines 152 - 183, The disconnectPlatform flow (method disconnectPlatform) can leave a partially-cleaned state if later steps like platformDataCleanupExecutor.deleteAccountAndRelations(...) fail after click/metric chunk deletions; add a defensive try-catch around the sequence of chunk deletions + deleteAccountAndRelations + deleteEmptyProject loop to detect partial failure, emit a structured error log including userId/orgId/accountId and totals (totalClickLogDeleted, totalMetricFactDeleted), record a monitoring/alert metric (e.g., PlatformCleanupPartialFailure) with those fields, and either rethrow after logging or persist a retry marker so operators can safely retry (document that retries are idempotent in logs). Ensure the try-catch is placed in disconnectPlatform and that platformDataCleanupExecutor.deleteAccountAndRelations(...) and the loop over projectIds are included in the protected section so any exception triggers the alert/logging path.src/main/java/com/whereyouad/WhereYouAd/domains/advertisement/persistence/repository/MetricFactRepository.java (1)
233-241: ⚡ Quick winMySQL 기준에서는
DELETE ... LIMIT호환성 이슈가 크지 않습니다
MetricFactRepository.deleteByPlatformAccountIdInBatch의 nativeDELETE FROM metric_fact ... LIMIT :batchSize는 현재 구성(MySQL Dialect/driver + docker-compose의mysql:8.0) 기준이면 동작 가능성이 높습니다(src/main/resources/application.yml의com.mysql.cj.jdbc.Driver/org.hibernate.dialect.MySQLDialect). 또한 테스트 환경에서 H2/PostgreSQL 전환 설정이 보이지 않아(별도application-test.*/ H2 의존성 없음) 기본 실행 경로에서 깨질 가능성은 낮습니다.
다만 로컬/CI에서DB_URL로 다른 DB(H2/PostgreSQL)로 바꾸면 동일 문법이 실패할 수 있으니, 그 경우에만 DB별 쿼리로 분기하는 쪽이 안전합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/whereyouad/WhereYouAd/domains/advertisement/persistence/repository/MetricFactRepository.java` around lines 233 - 241, The native query in MetricFactRepository.deleteByPlatformAccountIdInBatch uses "DELETE ... LIMIT :batchSize", which can fail on non-MySQL DBs; update the repository to use a DB-agnostic batch-delete approach: implement a two-step deletion in the service/repository layer that first selects a batch of primary keys (e.g., select id from metric_fact where platform_account_id = :platformAccountId order by id limit :batchSize) using a portable select, then call deleteAllByIdInBatch or a JPQL delete using those ids, or provide separate native queries per dialect and choose by current Hibernate dialect; ensure you modify MetricFactRepository.deleteByPlatformAccountIdInBatch (or add a new repository method used by the service) so the delete works across MySQL, H2, and PostgreSQL.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/docs/PlatformControllerDocs.java`:
- Around line 81-83: The ApiResponse labels in PlatformControllerDocs.java are
inconsistent with the actual error domains; update the `@ApiResponse` entries in
the PlatformControllerDocs class so each responseCode and its description use
the correct domain prefix and actual error identifier (e.g., use PLATFORM_404_1
/ PLATFORM_CONNECTION_NOT_FOUND for platform-related 404s and USER_404_1 /
USER_NOT_FOUND for user-related 404s) to match the thrown errors (like
UserErrorCode.USER_NOT_FOUND and platform error enums).
---
Nitpick comments:
In
`@src/main/java/com/whereyouad/WhereYouAd/domains/advertisement/persistence/repository/MetricFactRepository.java`:
- Around line 233-241: The native query in
MetricFactRepository.deleteByPlatformAccountIdInBatch uses "DELETE ... LIMIT
:batchSize", which can fail on non-MySQL DBs; update the repository to use a
DB-agnostic batch-delete approach: implement a two-step deletion in the
service/repository layer that first selects a batch of primary keys (e.g.,
select id from metric_fact where platform_account_id = :platformAccountId order
by id limit :batchSize) using a portable select, then call deleteAllByIdInBatch
or a JPQL delete using those ids, or provide separate native queries per dialect
and choose by current Hibernate dialect; ensure you modify
MetricFactRepository.deleteByPlatformAccountIdInBatch (or add a new repository
method used by the service) so the delete works across MySQL, H2, and
PostgreSQL.
In
`@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java`:
- Around line 152-183: The disconnectPlatform flow (method disconnectPlatform)
can leave a partially-cleaned state if later steps like
platformDataCleanupExecutor.deleteAccountAndRelations(...) fail after
click/metric chunk deletions; add a defensive try-catch around the sequence of
chunk deletions + deleteAccountAndRelations + deleteEmptyProject loop to detect
partial failure, emit a structured error log including userId/orgId/accountId
and totals (totalClickLogDeleted, totalMetricFactDeleted), record a
monitoring/alert metric (e.g., PlatformCleanupPartialFailure) with those fields,
and either rethrow after logging or persist a retry marker so operators can
safely retry (document that retries are idempotent in logs). Ensure the
try-catch is placed in disconnectPlatform and that
platformDataCleanupExecutor.deleteAccountAndRelations(...) and the loop over
projectIds are included in the protected section so any exception triggers the
alert/logging path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7f4e8a49-e8eb-495f-ae48-d1347d554cd6
📒 Files selected for processing (10)
src/main/java/com/whereyouad/WhereYouAd/domains/advertisement/persistence/repository/AdCampaignRepository.javasrc/main/java/com/whereyouad/WhereYouAd/domains/advertisement/persistence/repository/MetricFactRepository.javasrc/main/java/com/whereyouad/WhereYouAd/domains/click/persistence/repository/ClickLogRepository.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformService.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/exception/code/PlatformErrorCode.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/persistence/repository/PlatformConnectionRepository.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/PlatformController.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/docs/PlatformControllerDocs.java
💤 Files with no reviewable changes (2)
- src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformService.java
- src/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/PlatformController.java
kingmingyu
left a comment
kingmingyu
left a comment
There was a problem hiding this comment.
P2: 고생하셨습니다! metric_fact나 clicklog같은 데이터들은 커서 청크 단위로 분리해서 삭제하는 것도 좋은 것 같습니다! 근데 이렇게 트랜잭션을 분리하게 되면 어떤 데이터는 삭제되고 어떤 데이터는 삭제되지 않은 경우 데이터 정합성이 깨지는 문제가 발생할 수 있을 것 같습니다
그래서 제 생각에는 API에서 바로 처리하기보다 유저 soft delete 이후 30일이 지난 시점에 스케줄러에서 청크 단위로 정리하는 방식으로 가져가는 것도 괜찮아 보입니다. 이렇게 하면 한 번에 큰 트랜잭션을 잡지 않아도 되고 중간에 일부 청크가 실패하더라도 다음 스케줄 실행 시 재시도할 수 있을 것 같습니다. 이후 관련 데이터 정리가 모두 끝난 경우에만 유저 hard delete를 진행하면 더 안전할 것 같습니다. 추가로 만약 이렇게 한다면 회원 탈퇴시에 플랫폼 연동 해제를 요청하지 않아도 될 것 같습니다.
근데 이렇게 하면 사용자가 그냥 플랫폼 연동을 해제하고 싶은 경우에는 어떻게 처리할지 고민이 될 것 같습니다...
UserDeleteScheduler 쪽에서 플랫폼 연동해제 메서드를 호출하게 하는 방식으로 하면 가능할 것 같습니다! 이 방식으로 하면 회원 탈퇴 시 연동 해제를 요청하지 않아도 되고, 지금 만들어진 플랫폼 연동해제 API 엔드포인트도 그대로 유지해서 사용자가 단순히 수동으로 플랫폼 연동을 해제만하고 싶은 경우를 커버하도록 하면 어떨까요?? |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.java (1)
107-107:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win오타 수정이 필요합니다.
"함꼐" → "함께"로 수정해주세요.
📝 수정 제안
- //AdCampaign 삭제 시 CascadeType.ALL 로 인해 연관된 AdGroup, AdContent 도 함꼐 제거됨 + //AdCampaign 삭제 시 CascadeType.ALL 로 인해 연관된 AdGroup, AdContent 도 함께 제거됨🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.java` at line 107, Fix the typo in the comment inside PlatformDataCleanupExecutor: change "함꼐" to "함께" in the comment that explains cascade deletion of AdGroup and AdContent when deleting AdCampaign (the comment near the CascadeType.ALL note in PlatformDataCleanupExecutor).
🧹 Nitpick comments (1)
src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.java (1)
120-127: 빈 프로젝트 삭제 로직이 안전하게 설계되었습니다.AdCampaign과 MetricFact 카운트를 모두 체크하여 완전히 비어있을 때만 삭제하는 방어적 설계가 좋네요. 특히 Project가 여러 PlatformAccount의 캠페인을 포함할 수 있는 구조에서, count 체크로 다른 계정의 데이터가 남아있는 경우를 올바르게 처리합니다 ✓
참고로, MetricFact 청크 삭제가 중간에 실패할 경우 일부 MetricFact가 남을 수 있고, 이 경우
count > 0이므로 Project는 안전하게 보존됩니다. 다만 AdCampaign은 이미 삭제되어 orphan MetricFact가 발생할 수 있는데, 이는 PR 코멘트에서 ojy0903님이 언급하신 "청크 분리로 인한 부분 삭제 리스크"에 해당합니다.이 트레이드오프(대용량 처리 vs. 완전한 원자성)는 이미 팀에서 논의하고 선택하신 설계 결정이므로, 향후 운영 중 orphan 데이터가 발견되면 배치 정리 스크립트로 보완하시면 될 것 같습니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.java` around lines 120 - 127, The current deleteEmptyProject method may delete a Project if adCampaignRepository.countByProject_Id(...) and metricFactRepository.countByProject_Id(...) return 0, but partial/async deletions could leave orphan MetricFact after AdCampaigns were removed; to fix, re-check both counts immediately before calling projectRepository.deleteById(projectId) (i.e., perform a final verification/read-after-delete within deleteEmptyProject) so you only delete when both repositories still report zero, using the same adCampaignRepository.countByProject_Id and metricFactRepository.countByProject_Id calls in the deleteEmptyProject method to locate the check and delete logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/whereyouad/WhereYouAd/domains/user/domain/service/scheduler/UserDeleteScheduler.java`:
- Around line 40-48: The scheduler currently calls
platformService.disconnectAccountBySystem(accountId) for each account then
hardDeleteSingleUser(userId), but
PlatformDataCleanupExecutor.deleteAccountAndRelations(Long accountId) throws
PLATFORM_ACCOUNT_NOT_FOUND via
platformAccountRepository.findById(accountId).orElseThrow(...) which will break
retries if an account was already removed; update deleteAccountAndRelations (or
the disconnect wrapper called by UserDeleteScheduler) to treat
PLATFORM_ACCOUNT_NOT_FOUND as a no-op (log and return/continue) instead of
rethrowing so the operation is idempotent, preserving other error behavior and
keeping deleteClickLogChunk (REQUIRES_NEW) semantics intact.
---
Outside diff comments:
In
`@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.java`:
- Line 107: Fix the typo in the comment inside PlatformDataCleanupExecutor:
change "함꼐" to "함께" in the comment that explains cascade deletion of AdGroup and
AdContent when deleting AdCampaign (the comment near the CascadeType.ALL note in
PlatformDataCleanupExecutor).
---
Nitpick comments:
In
`@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.java`:
- Around line 120-127: The current deleteEmptyProject method may delete a
Project if adCampaignRepository.countByProject_Id(...) and
metricFactRepository.countByProject_Id(...) return 0, but partial/async
deletions could leave orphan MetricFact after AdCampaigns were removed; to fix,
re-check both counts immediately before calling
projectRepository.deleteById(projectId) (i.e., perform a final
verification/read-after-delete within deleteEmptyProject) so you only delete
when both repositories still report zero, using the same
adCampaignRepository.countByProject_Id and
metricFactRepository.countByProject_Id calls in the deleteEmptyProject method to
locate the check and delete logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2afd04b8-3a18-49a6-997b-8e9c86bfe5cf
📒 Files selected for processing (9)
src/main/java/com/whereyouad/WhereYouAd/domains/organization/domain/service/OrgService.javasrc/main/java/com/whereyouad/WhereYouAd/domains/organization/domain/service/OrgServiceImpl.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformDataCleanupExecutor.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformService.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/persistence/repository/PlatformConnectionRepository.javasrc/main/java/com/whereyouad/WhereYouAd/domains/user/domain/service/UserService.javasrc/main/java/com/whereyouad/WhereYouAd/domains/user/domain/service/scheduler/UserDeleteScheduler.javasrc/main/java/com/whereyouad/WhereYouAd/domains/user/exception/code/UserErrorCode.java
💤 Files with no reviewable changes (1)
- src/main/java/com/whereyouad/WhereYouAd/domains/user/exception/code/UserErrorCode.java
✅ Files skipped from review due to trivial changes (1)
- src/main/java/com/whereyouad/WhereYouAd/domains/organization/domain/service/OrgService.java
🚧 Files skipped from review as they are similar to previous changes (1)
- src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java
수정 완료했습니다. 기존에 플랫폼 연동 해제하는 API 는 '사용자가 수동으로 연동 해제 요청하는 경우' 커버를 위해 그대로 두고, 기존 회원 탈퇴 로직에서 UserDeleteScheduler 내부에서 플랫폼 계정 연동 해제도 자동으로 수행하도록 추가했습니다! |
|
확인했습니다! 근데 수동으로 API 해체 요청을 하는 경우에는 여전히 delete메서드 1회만 호출해서 트랜잭션이 부분적으로 실패하는 경우에는 데이터 정합성이 깨지는 문제가 남아있는 것 같습니다..!
|
… 정보 조회 시 Soft Delete 아닌 정보만 조회
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java (1)
219-225:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift프로젝트 정리 전에 계정 행을 지우면 재시도 커서가 사라집니다.
Line 220에서 계정을 hard delete한 뒤 Line 224-225의
deleteEmptyProject()가 실패하면, 다음 스케줄은DISCONNECTED계정을 다시 찾지 못해서 이projectIds를 재처리할 방법이 없어집니다. 그 결과 빈Project가 영구히 남을 수 있습니다.Project정리가 끝난 뒤 마지막에 계정을 삭제하거나, 별도의 cleanup 상태를 남겨 재시도 대상을 유지하는 쪽이 안전합니다.🔧 수정 방향 예시
- // AdCampaign + PlatformConnection + PlatformAccount 삭제 진행 - platformDataCleanupExecutor.deleteAccountAndRelations(accountId); - - // 비어있는 Project 엔티티 삭제 - for (Long projectId : projectIds) { - platformDataCleanupExecutor.deleteEmptyProject(projectId); - } + // 1) AdCampaign / PlatformConnection 등 관계 정리 + platformDataCleanupExecutor.deleteAccountRelations(accountId); + + // 2) 비어있는 Project 정리 + for (Long projectId : projectIds) { + platformDataCleanupExecutor.deleteEmptyProject(projectId); + } + + // 3) 마지막에 PlatformAccount hard delete + platformDataCleanupExecutor.deletePlatformAccount(accountId);또는
cleanup_status/아웃박스 같은 별도 재시도 커서를 두는 방법도 가능합니다.</details> As per coding guidelines, `SOLID 원칙, 의존성 주입(DI), 예외 처리(GlobalExceptionHandler)가 적절한지 보라.` <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java
around lines 219 - 225, The current flow deletes the account first via
platformDataCleanupExecutor.deleteAccountAndRelations(accountId) which loses the
retry cursor if subsequent deleteEmptyProject(projectId) calls fail; change the
sequence to first run all deleteEmptyProject(projectId) for each projectId and
only after all projects succeed call
platformDataCleanupExecutor.deleteAccountAndRelations(accountId), or
alternatively set/emit a persistent cleanup marker (e.g., set cleanup_status on
the account or write an outbox entry) before deleting the account so failures in
deleteEmptyProject can be retried; update PlatformServiceImpl to use the chosen
approach and ensure exceptions from deleteEmptyProject are handled/propagated so
the final account deletion is skipped on failure.</details> <!-- cr-comment:v1:215d01d40908c9cbcc064a8c --> _Source: Coding guidelines_ </blockquote></details> </blockquote></details>🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Outside diff comments: In `@src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.java`: - Around line 219-225: The current flow deletes the account first via platformDataCleanupExecutor.deleteAccountAndRelations(accountId) which loses the retry cursor if subsequent deleteEmptyProject(projectId) calls fail; change the sequence to first run all deleteEmptyProject(projectId) for each projectId and only after all projects succeed call platformDataCleanupExecutor.deleteAccountAndRelations(accountId), or alternatively set/emit a persistent cleanup marker (e.g., set cleanup_status on the account or write an outbox entry) before deleting the account so failures in deleteEmptyProject can be retried; update PlatformServiceImpl to use the chosen approach and ensure exceptions from deleteEmptyProject are handled/propagated so the final account deletion is skipped on failure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID:
f4c90683-408c-4482-9e02-789dfa759048📒 Files selected for processing (7)
src/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/PlatformServiceImpl.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/scheduler/PlatformAccountCleanupScheduler.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/domain/service/scheduler/PlatformDataCleanupExecutor.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/persistence/entity/PlatformAccount.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/persistence/repository/PlatformAccountRepository.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/PlatformController.javasrc/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/docs/PlatformControllerDocs.java🚧 Files skipped from review as they are similar to previous changes (2)
- src/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/docs/PlatformControllerDocs.java
- src/main/java/com/whereyouad/WhereYouAd/domains/platform/presentation/PlatformController.java
이 부분 생각을 못했었네요... 일단 PlatformAccount 내부에 PlatformStatus status 필드를 이용해서
이렇게 진행했습니다. 스케줄러 시간 조정이나 다른 피드백 있으면 남겨 주세요!! |
|
확인했습니다! 고생하셨습니다!! |
2 participants
📌 관련 이슈
🚀 개요
광고 플랫폼 연동해제와 관련 광고 엔티티 삭제 진행 API 추가
📄 작업 내용
📸 스크린샷 / 테스트 결과 (선택)
연동 해제 API 호출 전 상태 (Meta 와 Naver 연동 상태, AdCampaign, AdGroup, AdContent, MetricFact 에 각각 3개 데이터 존재, ClickLog 에는 존재 X)
연동 해제 전 DB 상태 캡쳐
PlatformAccount, PlatformConnection DB 상태플랫폼 연동 조회 API 를 통해 네이버, 메타 연동됨을 확인 (네이버는 세부 광고 정보 없음)
연동 해제 API 호출 (id 가 3번인 Meta 플랫폼 연동 해제)
연동 해제 후 DB 상태 캡쳐
PlaformAccount, PlaformConnectionAdCampaign, AdGroup, AdContent, MetricFact, ClickLog DB 상태
✅ 체크리스트
🔍 리뷰 포인트 (Review Points)
Summary by CodeRabbit
New Features
Refactor
Documentation