Repository navigation
fix(web): Last-Modified serializer uses datetime.timezone.utc instead of undeclared pytz - #340
Merged
Merged
Conversation
… of undeclared pytz winter.web.setup() imported pytz, which is only a dev dependency. Django stopped depending on pytz in 4.0, so a clean install of winter failed at setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrey-berenda
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winter.web.setup()importswinter.web.response_header_serializers, which importedpytz.pytzis only a dev dependency, and Django stopped depending on it in 4.0. A cleanpip install wintertherefore fails at setup:The bug exists since 30.0, when the minimum Django became 4.2. Projects that get
pytzfrom another dependency do not notice it. Found while upgrading winter-getting-started to 33.0.The serializer now uses
datetime.timezone.utc, which gives the same result.pytzstays a dev dependency because tests use it. No other third-party import inwinter/is missing from the runtime dependencies.🤖 Generated with Claude Code