Repository navigation
Conversation
@winter.json.register_encoder is @winter.json.json_encoder, like @winter.json.json_decoder, and @winter.web.register_url_regexp is @winter.web.url_regexp. The error for a second encoder of a type no longer refers to an unregister function that does not exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ository Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #351.
What
@winter.json.register_encoderis@winter.json.json_encoder, the counterpart of the existing@winter.json.json_decoder. The nameencoderwould have shadowed the modulewinter/json/encoder.py.@winter.web.register_url_regexpis@winter.web.url_regexp."T" already has a JSON encoderinstead of pointing to an unregister function that does not exist.Why
Decorators in Winter name what a thing is (
@route_get,@problem,@global_exception,@json_decoder,@type_inspectorsince #351);register_…named the mechanism, a global registry, for what is metadata about a type.🤖 Generated with Claude Code