Skip to content

Add Windows platform TLS verifier for TURN#50

Open
nickprice101 wants to merge 1 commit intoWonderInventions:developfrom
nickprice101:codex/turns-platform-verifier
Open

Add Windows platform TLS verifier for TURN#50
nickprice101 wants to merge 1 commit intoWonderInventions:developfrom
nickprice101:codex/turns-platform-verifier

Conversation

@nickprice101
Copy link
Copy Markdown

What changed

This PR ports the addon forward to a newer libwebrtc baseline and adds a Windows platform certificate verifier for secure TURN/TLS connections.

Key pieces:

  • adds a Windows CryptoAPI-backed SSLCertificateVerifier
  • injects that verifier for secure TLS sockets used by the packet socket factory
  • keeps plain TURN/TCP behavior unchanged
  • includes the compatibility and build-system updates needed to build against a newer libwebrtc tree
  • preserves native logging hooks used to diagnose TURN/TLS failures

Why

The failing TURN-over-TLS path reproduced as:

  • TCP connect succeeded
  • TLS started
  • BoringSSL verification failed with unable to get local issuer certificate
  • TURN never sent ALLOCATE

On the same machine and credentials, plain turn:3478 succeeded, including the 401 challenge and subsequent successful ALLOCATE.

That showed the breakage was in the native TLS validation path, not TURN auth.

This change lets the Windows addon validate TURN/TLS chains against the platform trust store instead of failing in the built-in verification path.

Validation

  • built wrtc.node successfully on Windows against the newer libwebrtc tree
  • reran the TURN harness with native logs enabled
  • confirmed turns:443 now completes TLS, sends ALLOCATE, and gathers a relay candidate
  • confirmed turn:3478 still succeeds

@nickprice101 nickprice101 marked this pull request as ready for review April 12, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant