Skip to content

Update get_metadata_by_mid() to return null instead of false when metadata is missing #11919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arifrahmanbb wants to merge 3 commits into
base: trunk
Choose a base branch
from
+6 −6
Open

Update get_metadata_by_mid() to return null instead of false when metadata is missing #11919

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc38e68
Update get_metadata_by_mid() to return null instead of false when met…
arifrahmanbb May 21, 2026
83d6664
Merge branch 'trunk' into fix/64986-metadata-return-null
arifrahmanbb May 21, 2026
613e37a
Merge branch 'trunk' into fix/64986-metadata-return-null
arifrahmanbb May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/wp-includes/meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,8 +800,8 @@ function metadata_exists( $meta_type, $object_id, $meta_key ) {
* @param string $meta_type Type of object metadata is for. Accepts 'blog', 'post', 'comment', 'term',
* 'user', or any other object type with an associated meta table.
* @param int $meta_id ID for a specific meta row.
* @return stdClass|false {
* Metadata object, or boolean `false` if the metadata doesn't exist.
* @return stdClass|null {
* Metadata object, or null if the metadata doesn't exist.
*
* @type string $meta_key The meta key.
* @type mixed $meta_value The unserialized meta value.
Expand All @@ -818,17 +818,17 @@ function get_metadata_by_mid( $meta_type, $meta_id ) {
global $wpdb;

if ( ! $meta_type || ! is_numeric( $meta_id ) || floor( $meta_id ) != $meta_id ) {
return false;
return null;
}

$meta_id = (int) $meta_id;
if ( $meta_id <= 0 ) {
return false;
return null;
}

$table = _get_meta_table( $meta_type );
if ( ! $table ) {
return false;
return null;
}

/**
Expand Down Expand Up @@ -861,7 +861,7 @@ function get_metadata_by_mid( $meta_type, $meta_id ) {
$meta = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $table WHERE $id_column = %d", $meta_id ) );

if ( empty( $meta ) ) {
return false;
return null;
}

if ( isset( $meta->meta_value ) ) {
Expand Down
Loading