Skip to content

Upload: Fix inaccurate HEIC/HEIF MIME type mapping#11920

Open
NoumaanAhamed wants to merge 1 commit into
WordPress:trunkfrom
NoumaanAhamed:fix/65297-add-heic-heif-support
Open

Upload: Fix inaccurate HEIC/HEIF MIME type mapping#11920
NoumaanAhamed wants to merge 1 commit into
WordPress:trunkfrom
NoumaanAhamed:fix/65297-add-heic-heif-support

Conversation

@NoumaanAhamed
Copy link
Copy Markdown

@NoumaanAhamed NoumaanAhamed commented May 21, 2026

Summary

Fixes inaccurate HEIC/HEIF MIME type mappings. Previously, all HEIF-family uploads (.heif, .heics, .heifs) were incorrectly mapped to and renamed as .heic because the $mime_to_ext array collapsed all variants into the heic extension.

Additionally, this PR fixes two related issues:

  1. .heics and .heifs were missing from the wp_ext2type() image array, causing them not to be recognized as images in the Media Library.
  2. Sub-size generation skipped non-image/heic HEIF variants because of a hardcoded mime type check.

Changes

src/wp-includes/functions.php

  • Updated the $mime_to_ext array in wp_check_filetype_and_ext() to map each HEIF MIME type to its proper, distinct extension:
    • image/heifheif
    • image/heic-sequenceheics
    • image/heif-sequenceheifs
  • Added 'heic' to the $heic_images_extensions trigger array.
  • Added 'heics' and 'heifs' to the image types array in wp_get_ext_types().
  • Removed outdated comments indicating all HEIC/HEIF formats commonly use .heic.

src/wp-admin/includes/image.php

  • Replaced the explicit 'image/heic' === $mime_type check in wp_generate_attachment_metadata() with a call to wp_is_heic_image_mime_type(). This ensures all HEIF variants (not just image/heic) correctly trigger sub-size generation.

Testing

Test Result
Upload .heic file ✅ Remains .heic, sub-sizes generated correctly
Upload .heif file ✅ Remains .heif, sub-sizes generated correctly

Trac ticket: https://core.trac.wordpress.org/ticket/65297

Use of AI Tools

AI assistance: No

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mohamedahamed.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant