-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Site Health: Cache the full results and a timestamp in the status transient #12181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gziolo
wants to merge
44
commits into
WordPress:trunk
Choose a base branch
from
gziolo:fix/65232-cache-site-health-results
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
08ee01b
Site Health: Cache the full results and a timestamp in the status tra…
gziolo b8ee347
Tests: Fix Site Health AJAX tests on multisite
gziolo d3a5e8a
Fix PHPStan `argument.type` error for mixed being passed to `json_enc…
westonruter 24aa96a
Fix PHPStan `argument.type` error for `wp_unslash()` expecting `array…
westonruter 26bf323
Simply accessing counts
westonruter 768e598
Add void return type hints
westonruter 1914559
Update dispatch_result_request method to always return array
westonruter 46c32aa
Use native property type hint
westonruter 4572595
fixup! Update dispatch_result_request method to always return array
westonruter 75cc4e8
Fix PHPStan issues in tests
westonruter 3ca1452
Site Health: Cache the full results in a dedicated, non-autoloaded tr…
gziolo 5326eeb
Apply suggestions from code review
gziolo d381c19
Site Health: Refine the detail cache types and parameter naming.
gziolo 840067f
Site Health: Seed the JS results array from PHP.
gziolo 7f5fdcc
Site Health: Cache only locale-independent result data.
gziolo a6d1561
Site Health: Reduce duplication in the status cache accessors.
gziolo e8cd113
Merge branch 'trunk' into fix/65232-cache-site-health-results
westonruter ac94106
Merge branch 'trunk' into fix/65232-cache-site-health-results
westonruter 3c8ed42
Add type definition for tests
westonruter 069c8d9
Fix return type of get_instance() method
westonruter a135f1e
Specify shape of $counts param for set_site_status_counts
westonruter e67b256
Add array type for $counts param for normalize_status_counts()
westonruter 00b290c
Reformat return array shape
westonruter 99b88ba
Factor out array shape into reusable type
westonruter a8f86c9
Reduce specificity of pre-normalized types
westonruter abe39f3
Merge branch 'trunk' into fix/65232-cache-site-health-results
westonruter 1c5ac6d
Eliminate redundnat type guards when reading from cache
westonruter a86ed9c
Leverage JSON schema for validation and use object for results instea…
westonruter 61b1c6f
Merge branch 'trunk' into fix/65232-cache-site-health-results
westonruter 17a9824
Refactor handling of test results
westonruter f577e0a
Fix error when saving transient with identical value
westonruter 48380a1
Fix ajax tests
westonruter 0718c3f
Site Health: Compute detailed status counts at runtime
gziolo b718838
Site Health: Specialize the detailed status cache reader
gziolo f727ddb
Site Health: Fix storing test results in JavaScript
gziolo 26799d5
Site Health: Clarify detailed result documentation
gziolo a84ac00
Site Health: Validate scheduled test results
gziolo 9ea12a3
Site Health: Compare detail cache with correct transient
gziolo 832da82
Site Health: Ignore results without test identifiers
gziolo 3e59308
Site Health: Clarify detail result validation
gziolo 52ca604
Site Health: Return first AJAX save error
gziolo e3a9e4e
Site Health: Require detailed status timestamps
gziolo 58edf87
Site Health: Store freshest verified results
gziolo 165fbeb
Site Health: Add status cache error messages
gziolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.